aout: don't update the clock while stopping
This fixes the following assert:
src/player/timer.c:301: void vlc_player_UpdateTimer(vlc_player_t *, vlc_es_id_t *, _Bool, const struct vlc_player_timer_point *, vlc_tick_t, unsigned int, unsigned int): assertion "point->ts != VLC_TICK_INVALID" failed
Merge request reports
Activity
changed milestone to %4.0
added Component::Core: Clock label
added MRStatus::Acceptable label
BTW, the
timing.lock
says it's protecting (among others)first_pts
. But there are a few cases where it's read without a lock. In particular, if 2 threads callvlc_aout_stream_Play()
at the same time, you don't know which will write the value. Luckily it's only called by the (audio) decoder thread.added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations. MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 43 commits
-
58dd504d...ad65c058 - 41 commits from branch
videolan:master
- 3469a537 - aout: don't update the clock while stopping
- fa9f010c - audiotrack: check timestamp position
-
58dd504d...ad65c058 - 41 commits from branch
enabled an automatic merge when the pipeline for fa9f010c succeeds