avcodec: update audio encoder to use ch_layout for channel ordering
It was introduced in 2022-03-15 - lavc 59.24.100 /lavu 57.24.100 , and channel_layout was deprecated and will be removed at some point.
One alternative with new API set would be just to set custom order, so we wouldn't need to reorder channels in vlc end, but I decided to go with smaller changes.
I tested this with 7.1 channel mp4 file for channel testing, checked with audacity on audio, encoded with ffmpeg and vlc and checked audio output with audacity to compare. Also tested that from 7.1 to stereo worked.
Merge request reports
Activity
- Resolved by Steve Lhomme
- Resolved by Ilkka Ollakka
changed milestone to %4.0
added Component::Decoders label
added MRStatus::InReview label
added 5 commits
-
8b0bbc88...5df262a4 - 4 commits from branch
videolan:master
- 8011c9be - avcodec: update encoder to use ch_layout for channel ordering
-
8b0bbc88...5df262a4 - 4 commits from branch
- Resolved by Steve Lhomme
- Resolved by Ilkka Ollakka
added MRStatus::Acceptable label and removed MRStatus::InReview label
- Resolved by Ilkka Ollakka
We should have the same thing for the audio decoder which is currently using
p_context->channels
andp_context->channel_layout
.
mentioned in merge request !3872 (merged)
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 38 commits
-
ded4dab1...8b96a63e - 35 commits from branch
videolan:master
- 4681be5c - avcodec: use p_enc audio channels instead of context channels in encoder
- 062e1b55 - avcodec: add handling of new ch_layout in audio encoder
- f6de0693 - avcodec: use ch_layout for channel layout in audio encoder
Toggle commit list-
ded4dab1...8b96a63e - 35 commits from branch