Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • VLC VLC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.8k
    • Issues 3.8k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 287
    • Merge requests 287
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLANVideoLAN
  • VLCVLC
  • Merge requests
  • !3750

tools: raise the minimum CMake version to 3.20 to properly build Android targets

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Steve Lhomme requested to merge robUx4/vlc:android-cmake into master Jun 01, 2023
  • Overview 3
  • Commits 4
  • Pipelines 1
  • Changes 6

This should provide proper Android support. This version was released 2 years ago.

We should be using the Android CMake toolchain file. We're supposed to use it with the Android SYSTEM_NAME

  • https://developer.android.com/studio/projects/configure-cmake
  • https://developer.android.com/ndk/guides/cmake

Some patches extracted from !3728 (merged).

The update to a new CMake requirement and using 3.26 is fine with Android, as seen in !3752 (closed).

The bad news is that all Docker images currently use an older CMake (Debian bullseye is using 3.18). So if this works, we should update the Docker images first to build a newer CMake version (using bullseye-backports). Otherwise we'll end up building CMake for every CI run, which will makes considerably slower. While doing that, we should do the same with Meson which is always rebuilt as well...

So there's something going wrong with the "recommended" toolchain file usage, maybe the overriding of some values in our toolchain file.

Edited Jun 02, 2023 by Steve Lhomme
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: android-cmake

VideoLAN code repository instance