mmdevice: move MTA initialization to the worker thread
MTA was checked in the Open function. As this function is called from libvlc thread, this implies that a user of libvlc should have its own thread in MTA which may not be possible for various reasons.
- MuteSet, VolumeSet, Play, DeviceSelect, Close callback don't require MTA
- Flush, Pause and Start callbacks still require MTA, but as these functions are called from VLC internal thread this is a lesser issue
Merge request reports
Activity
changed milestone to %4.0
added Component::Audio: Windows plugins label
- Resolved by Steve Lhomme
Nit: since this is a wait-once case, a binary semaphore initialized to zero will dramatically simplify the code compared to mutex and condition variable.
- Resolved by Denis Charmet
added 1 commit
- ba640ff5 - mmdevice: move MTA initialization to the worker thread
added 1 commit
- 2a920c8c - mmdevice: move MTA initialization to the worker thread
added MRStatus::InReview label
added MRStatus::Acceptable label and removed MRStatus::InReview label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations. MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 112 commits
-
2a920c8c...8bc05708 - 111 commits from branch
videolan:master
- 2fa81b6f - mmdevice: move MTA initialization to the worker thread
-
2a920c8c...8bc05708 - 111 commits from branch
enabled an automatic merge when the pipeline for 2fa81b6f succeeds
@robUx4 shouldn't this be backported?
added Status::BackportCandidate label