Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • VLC VLC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,801
    • Issues 3,801
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 256
    • Merge requests 256
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLANVideoLAN
  • VLCVLC
  • Merge requests
  • !3732

qt/qml: Update the 'Media Library' toggle behavior

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Benjamin Arnaud requested to merge bunjee/vlc:ci-classic into master May 26, 2023
  • Overview 36
  • Commits 7
  • Pipelines 13
  • Changes 9

This MR updates the 'Media Library' toggle behavior, by adding a 'Media Library' checkable entry in the menu bar. This makes the player view accessible at any time, even when a media is not playing. That's actually the behavior we have on 3.x with the MediaLibrary / Playqueue ancestor.

This MR also updates the TopBar QML to fit our design choices surrounding classic. In particular only displaying the menu bar and nothing else when the player is pinned.

Overall, it's the closest we've been from a 3.x legacy UI ever, which should reassure the more conservatory types among us.

Fixes #28174 (closed)

NOTE: The media_library.svg is a placeholder for now.

3us60lvm5w

Edited Jun 02, 2023 by Benjamin Arnaud
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ci-classic

VideoLAN code repository instance