Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • VLC VLC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.8k
    • Issues 3.8k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 285
    • Merge requests 285
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLANVideoLAN
  • VLCVLC
  • Merge requests
  • !3725

transcode: don't use video encoder video can't be sent downstream

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Steve Lhomme requested to merge robUx4/vlc:rtp-downstream-crash into master May 24, 2023
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 1

This is the same check done for audio and spu.

Otherwise we end up sending blocks to a id->downstream_id that doesn't exist. And it crashes.

Regression from 8177a1d6.

The crash is easy to reproduce with --sout=#transcode{vcodec=FFV1,acodec=none,scodec=none}:rtp{sdp=rtsp://localhost:8554/}

Edited May 25, 2023 by Steve Lhomme
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rtp-downstream-crash

VideoLAN code repository instance