macosx: Fix incorrect mouse entry and exit tracking behaviour of VLCTrackingView around scrolling
mouseEntered
and mouseExited
events only seem to be sent when the mouse cursor is moved, causing issues when the VLCTrackingView
is inside a scrollview and the view itself moves. This means the cursor does not move but is not hovering the item anymore, with the view unaware of this.
Fix by checking the mouse position after the tracking areas are updated inside VLCTrackingView
After fix:
Screen_Recording_2023-05-06_at_16.47.14
Before fix:
Screen_Recording_2023-05-06_at_16.48.22
Signed-off-by: Claudio Cambra developer@claudiocambra.com
Merge request reports
Activity
assigned to @claucambra
changed milestone to %4.0
added Component::Interface: macOS Platform::macOS labels
added MRStatus::Reviewable label
added MRStatus::Acceptable label and removed MRStatus::Reviewable label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 26 commits
-
b36da2e7...c6d6da2d - 22 commits from branch
videolan:master
- 99d86383 - macosx: Extract contents of mouseExited in VLCTrackingView to separate method
- 30005195 - macosx: Extract contents of mouseEntered in VLCTrackingView to separate method
- ea7774a2 - macosx: Store whether cursor is inside VLCTrackingView or not
- 49ade81d - macosx: Check if mouse is still within VLCTrackingArea once the tracking area is updated
Toggle commit list-
b36da2e7...c6d6da2d - 22 commits from branch
enabled an automatic merge when the pipeline for 49ade81d succeeds