plugins: add type strictness to plugin descriptor macros
i.e. check the type of the values provided, rather than just blindly casting, and thus allow mistakes to get caught with compilation errors.
i once lost some hours tracking down the cause of a crash that this type strictness would have prevented.
also, the third commit statically checks that the length of choice list item and label arrays are identical. [Moved to separate MR !333 (closed)]
Merge request reports
Activity
mentioned in commit jnqnfe/vlc@834e8aec
mentioned in merge request !320 (merged)
added MRStatus::NotCompliant label
- Resolved by Lyndon Brown
Fails on SRT module
- Resolved by Lyndon Brown
- Resolved by Lyndon Brown
- Resolved by Lyndon Brown
You should rather use compound litterals rather than declaring names for those values.
- Resolved by Lyndon Brown
Hi,
We can't put assertions in there. Been discussed several times already, breaks external modules.
And we already have a test case to make sure that modules descriptors don't trigger crashes, so I don't even see the point.
Edited by Rémi Denis-Courmont
added MRStatus::InReview label and removed MRStatus::NotCompliant label
added 1 commit
- 6a2ab442 - plugins: add type strictness to plugin descriptor macros
mentioned in merge request !333 (closed)
mentioned in merge request !329 (merged)
added MRStatus::Acceptable label and removed MRStatus::InReview label