Skip to content
Snippets Groups Projects

plugins: add type strictness to plugin descriptor macros

Merged Lyndon Brown requested to merge jnqnfe/vlc:plugins_tsm into master

i.e. check the type of the values provided, rather than just blindly casting, and thus allow mistakes to get caught with compilation errors.

i once lost some hours tracking down the cause of a crash that this type strictness would have prevented.

also, the third commit statically checks that the length of choice list item and label arrays are identical. [Moved to separate MR !333 (closed)]

Edited by Lyndon Brown

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Steve Lhomme
  • Lyndon Brown added 3 commits

    added 3 commits

    • eb0873f2 - srt: move choice list labels to header
    • 715b8764 - plugins: add type strictness to plugin descriptor macros
    • 96adaaa9 - plugins: assert value/label array length match

    Compare with previous version

  • Lyndon Brown added 2 commits

    added 2 commits

    • aa5f750d - plugins: add type strictness to plugin descriptor macros
    • ed0f8f1b - plugins: assert value/label array length match

    Compare with previous version

  • Lyndon Brown resolved all threads

    resolved all threads

  • Lyndon Brown added 1 commit

    added 1 commit

    • 6a2ab442 - plugins: add type strictness to plugin descriptor macros

    Compare with previous version

  • Lyndon Brown changed the description

    changed the description

  • Lyndon Brown mentioned in merge request !333 (closed)

    mentioned in merge request !333 (closed)

  • Lyndon Brown resolved all threads

    resolved all threads

  • Lyndon Brown changed the description

    changed the description

  • Lyndon Brown mentioned in merge request !329 (merged)

    mentioned in merge request !329 (merged)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading