Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • VLC VLC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,725
    • Issues 3,725
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 224
    • Merge requests 224
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLANVideoLAN
  • VLCVLC
  • Merge requests
  • !3153

thumbnail: rework API to fix use-after-free

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Thomas Guillem requested to merge tguillem/vlc:thumbnail-fix-2 into master Jan 24, 2023
  • Overview 17
  • Commits 3
  • Pipelines 9
  • Changes 8

Before 3b26eefc, the caller was not responsible to destroy the request but he could cancel it via:

vlc_thumbnailer_Cancel() WaitForTheCb() ReleaseResourceAssociatedWithTheCb()

This new commit, in addition with 3b26eefc (that was not complete), allow the user to cancel/destroy the request, without waiting for any callback:

vlc_thumbnailer_DestroyRequest() ReleaseResourceAssociatedWithTheCb()

vlc_thumbnailer_Cancel() has been renamed to vlc_thumbnailer_DestroyRequest(), this new call must always be called to release resources and can be called before receiving the callback in order to cancel it.

Fixes #27766 (closed)

Edited Jan 24, 2023 by Thomas Guillem
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: thumbnail-fix-2

VideoLAN code repository instance