Skip to content
Snippets Groups Projects

macosx: Simplify VLCLibraryMenuController

Merged macosx: Simplify VLCLibraryMenuController
claucambra/vlc:work/media-library-context-menus into master
All threads resolved!
Merged Claudio Cambra requested to merge claucambra/vlc:work/media-library-context-menus into master
All threads resolved!

Rather than use two separate NSMenus depending on the state of the represented media item of the controller, just use one menu and hide/show menu items as requested

Simplifies public API and use by clients, requiring for instance delegation for only one menu rather than two

Signed-off-by: Claudio Cambra developer@claudiocambra.com

Merge request reports

Merge request pipeline #295392 passed

Stage:

    Merge request pipeline passed for 667690ef

    Approved by
    Marvin Scholz David Felix Paul Kühne Jean-Baptiste Kempf

    Merged by Jean-Baptiste KempfJean-Baptiste Kempf 2 years ago (Dec 21, 2022 12:39pm UTC)

    Merge details

    • Changes merged into master with 667690ef.
    • Deleted the source branch.
    • Auto-merge enabled

    Pipeline #295400 passed

    Stage:

      Pipeline passed for 667690ef on master

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
    • Marvin Scholz approved this merge request

      approved this merge request

    • Bart - The Review Bot added MRStatus::InReview label and removed MRStatus::Acceptable label

      added MRStatus::InReview label and removed MRStatus::Acceptable label

    • Claudio Cambra added 1 commit

      added 1 commit

      • 40580c51 - macosx: Use weakObjectsHashTable for VLCLibraryMenuController menuitems

      Compare with previous version

    • David approved this merge request

      approved this merge request

    • David resolved all threads

      resolved all threads

    • Bart - The Review Bot added MRStatus::Acceptable label and removed MRStatus::InReview label

      added MRStatus::Acceptable label and removed MRStatus::InReview label

    • Bart - The Review Bot added MRStatus::Accepted label and removed MRStatus::Acceptable label

      added MRStatus::Accepted label and removed MRStatus::Acceptable label

    • Bart - The Review Bot
      Bart - The Review Bot @Bart ·
      Developer

      MR Acceptance result

      :tada: This MergeRequest has been Accepted! Congratulations.

      MR acceptance checks details:

      • :white_check_mark: MR should be considered mergeable by Gitlab
      • :white_check_mark: Last pipeline should be successful
      • :white_check_mark: MergeRequest should have at least one external review and/or vote
      • :white_check_mark: All threads should be resolved, have votes and score > 0
      • :white_check_mark: MergeRequest should have no activity (threads/votes) for (72h/72h)

      This message was automatically generated by homer-bot.

    • Jean-Baptiste Kempf added 107 commits

      added 107 commits

      • 40580c51...09f99896 - 104 commits from branch videolan:master
      • 821bbe33 - macosx: Separate menu creation into separate methods
      • b032d3cd - macosx: Streamline VLCLibraryMenuController, use one NSMenu with hideable...
      • 667690ef - macosx: Use weakObjectsHashTable for VLCLibraryMenuController menuitems

      Compare with previous version

      Toggle commit list
    • Jean-Baptiste Kempf enabled an automatic merge when the pipeline for 667690ef succeeds

      enabled an automatic merge when the pipeline for 667690ef succeeds

    • Jean-Baptiste Kempf merged

      merged

      • Please register or sign in to reply

      VideoLAN code repository instance