Skip to content

macos: clean up config margin lookup

Lyndon Brown requested to merge jnqnfe/vlc:margins into master

Slims down LOC from ~330 to ~45; the table makes it much easier to review the differences.

I don't have a mac with which to experiment with this to see if any of the numbers could be adjusted to further simplify things. Perhaps someone with a mac could look into it further?

  • I find it odd that the default 20/23 is so much larger than the values otherwise used.
  • I also notice that several types, including float, are missing (thus relying upon those defaults).
  • The CONFIG_ITEM_STRING_LIST and CONFIG_ITEM_RANGED_INTEGER defines only exist in this file and seems to be a hack just to get different margins for these string/int variants.
Edited by Lyndon Brown

Merge request reports

VideoLAN code repository instance