CI: use distcheck exclusively for building/testing

make_check_wrapper.sh + make dist does not replace make distcheck.

make distcheck is used as single source of truth. To still get stack traces, move make check outside of the script and retrieve the exit code of make distcheck.

This should catch issues like #27470 (closed) upfront.

Looking more closely, not sure about noinst_PROGRAMS since it is also in bin/ ... maybe that one need not be overridden.

added MRStatus::Reviewable label

cc @tguillem who introduced the dist call rather than a distcheck. Maybe because the check is done as @JohannesKauffmann says ?

added MRStatus::InReview label and removed MRStatus::Reviewable label

changed milestone to %4.0

added Component:: CI label

added 2 commits

• de4b02d0 - CI: enable distcheck on merge builds
• 6492397e - CI: disable tests during distcheck

Compare with previous version

resolved all threads

added MRStatus::Acceptable label and removed MRStatus::InReview label

approved this merge request

I'd rather run the tests in make distcheck than with make check if possible though, given that it will run the tests against the dist-archive build and not the one from the tree. Also, I expected make distcheck to rebuild the tree, shouldn't it replace the whole thing instead ?

Still, approving since checking the dist is better anyway.

approved this merge request

Maybe the tests are run with -j4 because there was an issue with higher numbers ? In which case it's better to separate from the distcheck.

That being said, the make -j$NCPU and make -j$NCPU distcheck calls seem redundant. It might be better to do make -j$NCPU distcheck directly, and then run the check on that build directory (in vlc-dev-4.0.0). But that problem already existed in nightly builds.

added MRStatus::InReview label and removed MRStatus::Acceptable label

added 1 commit

• 14ce9abd - CI: use distcheck exclusively for building/testing

Compare with previous version

resolved all threads

changed title from CI: enable distcheck on merge builds to CI: use distcheck exclusively for building/testing

changed the description