contrib: chromaprint: use CMAKE_CXX_IMPLICIT_LINK_LIBRARIES to get the C++ runtime
Submitted upstream https://github.com/acoustid/chromaprint/pull/119
We can't remove the dummy.cpp
for that one. We can do it when we can detect a (published) version in configure.ac that has this patch merged.
Merge request reports
Activity
changed milestone to %4.0
added Component::Build system: Contribs label
- Resolved by Steve Lhomme
I fail to see why you can't remove
dummy.cpp
. If it's taken from the system, it does not matter what is (not) inLibs.private
.
added MRStatus::Reviewable label
added MRStatus::InReview label and removed MRStatus::Reviewable label
added MRStatus::Acceptable label and removed MRStatus::InReview label
mentioned in merge request !2495 (merged)
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 12 commits
-
e2a0a6b5...8d5c0815 - 10 commits from branch
videolan:master
- 7a772424 - contrib: chromaprint: use CMAKE_CXX_IMPLICIT_LINK_LIBRARIES to get the C++ runtime
- 4c362388 - chromaprint: remove dummy.cpp
-
e2a0a6b5...8d5c0815 - 10 commits from branch
enabled an automatic merge when the pipeline for 4c362388 succeeds