contrib: fail the build if prebuilt fail

In some cases the tarballs are corrupted. If the extraction of the tarball fails the build will fail (or may use part of an old extraction).

The - was introduced in 5d2ed11e.

This will make the cause of failures like https://code.videolan.org/videolan/vlc/-/jobs/1127819 more visible.

changed milestone to %4.0

added Component::Build system: Contribs label

Can we fasttrack this MR?

resolved all threads

approved this merge request

approved this merge request

added MRStatus::Acceptable label

merged

MR fast-tracked to unbreak the CI.

added MRStatus::Accepted label and removed MRStatus::Acceptable label

I agree with Steve. There's no point fast tracking this. It won't unbreak anything

It did, but just because it forces fresh contribs to be built.

So I guess the tar tf we do in CI to check the tarball is actually useless and a waste of time if it does not detect and prevent uploading corrupt archives…

IMO it's not useless because it also generates an error if that doesn't work. But we need to verify the upload is correct. There seems to be a hash with it so it should be doable.

I don't think the tarball corruption happens during the creation.