contrib: qt: Fix shasum check filelist format
This kind of error occurred on darwin when shasum check attempt wat made on Qt contribs :
+ make fetch
grep -- " qtdeclarative-everywhere-src-5.15.1.tar.xz$" "../src/qtdeclarative/SHA512SUMS" && (cd ../tarballs && shasum -a 512 --check /dev/stdin) < "../src/qtdeclarative/SHA512SUMS"
193ec706b764330a2ae00614b13482b7586642f9cfd32458e8c975daa07ba25f0f9887de0918c4034f52f613b860677c09c46a3b7d07d4229446cfc0805bcccd qtdeclarative-everywhere-src-5.15.1.tar.xz
shasum: /dev/stdin: no properly formatted SHA checksum lines found
make: *** [.sum-qtdeclarative] Error 1
umxprime@umxprime-m1 ~ % shasum -a 512 /Users/umxprime/code/videolan/vlc/contrib/tarballs/qtdeclarative-everywhere-src-5.15.1.tar.xz
193ec706b764330a2ae00614b13482b7586642f9cfd32458e8c975daa07ba25f0f9887de0918c4034f52f613b860677c09c46a3b7d07d4229446cfc0805bcccd /Users/umxprime/code/videolan/vlc/contrib/tarballs/qtdeclarative-everywhere-src-5.15.1.tar.xz
umxprime@umxprime-m1 ~ %
This was mainly due to a missing whitespace between the sum and the filename in the SHA512SUMS list
Merge request reports
Activity
added MRStatus::Acceptable label
According to Wikipedia the line(s) should look like
{hash} SPACE (ASTERISK|SPACE) [{directory} SLASH] {filename}
So we indeed we need either an asterisk or a space.
The asterisk means binary mode, which sounds like what we would want for tarballs but so far we don't use it anywhere.
added Component::Build system: Contribs label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
added 46 commits
-
4b4ac206...90dcfa0e - 45 commits from branch
videolan:master
- 37496d31 - contrib: qt: Fix shasum check filelist format
-
4b4ac206...90dcfa0e - 45 commits from branch
enabled an automatic merge when the pipeline for 37496d31 succeeds
changed milestone to %4.0