contrib: dvdnav: do not force a packing style
We should use the same packing as libdvdread. It's done and made public through a header. But we must also use the compiler the same way. libdvdread doesn't force -mno-ms-bitfields.
Alternative fix from !2377 (closed). It avoids some crashes in files that otherwise crash. But the menus don't always work.
Merge request reports
Activity
changed milestone to %4.0
added Component::Build system: Contribs label
Proposed for merging here libdvdnav!51 (closed)
added MRStatus::Reviewable label
mentioned in merge request !2402 (merged)
mentioned in merge request !2377 (closed)
- Resolved by Alexandre Janniaux
It's probably easier to use the
cc_cv_cflags_*
at configure time to enforce a cache value, rather than patching the configure.ac file.
added MRStatus::Acceptable label and removed MRStatus::Reviewable label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
- Resolved by Steve Lhomme
I’m not sure this is the right thing to do.
added MRStatus::InReview label and removed MRStatus::Accepted label
Reopening as it's a much simpler fix than !2416 (merged) which is less likely to be merged.
mentioned in merge request !2416 (merged)
added MRStatus::Acceptable label and removed MRStatus::InReview label
added MRStatus::Accepted label and removed MRStatus::Acceptable label