vout: fix deadlock on ICC profile update

This was taking more locks than necessary, causing a possible deadlock, because window events are not supposed to lock the window lock.

The display lock is more than sufficient to guard access to this field.

Fixes: 354f3aae

added MRStatus::Reviewable label

added MRStatus::InReview label and removed MRStatus::Reviewable label

resolved all threads

resolved all threads

approved this merge request

added MRStatus::Acceptable label and removed MRStatus::InReview label

approved this merge request

mentioned in merge request !2379 (merged)

added MRStatus::Accepted label and removed MRStatus::Acceptable label

MR Acceptance result

This MergeRequest has been Accepted! Congratulations.

MR acceptance checks details:

• MR should be considered mergeable by Gitlab
• Last pipeline should be successful
• MergeRequest should have at least one external review and/or vote
• All threads should be resolved, have votes and score > 0
• MergeRequest should have no activity (threads/votes) for (72h/72h)

This message was automatically generated by homer-bot.

added 57 commits

• 802bd933...1eb10010 - 56 commits from branch videolan:master
• 575bef69 - vout: fix deadlock on ICC profile update

Compare with previous version

enabled an automatic merge when the pipeline for 575bef69 succeeds

merged

I didn't want to disturb this MR to get it merged ASAP, but for the record: this also technically fixes a race condition where the old icc_profile could be freed before the display is informed of the new profile, which adds further justification to only changing this state only while holding the display lock.

changed milestone to %4.0