Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • VLC VLC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,796
    • Issues 3,796
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 247
    • Merge requests 247
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLANVideoLAN
  • VLCVLC
  • Merge requests
  • !2363

macosx: Refactor setupVoutForWindow in VLCVideoOutputProvider

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Claudio Cambra requested to merge claucambra/vlc:work/refactor-setupVoutForWindow into master Aug 10, 2022
  • Overview 1
  • Commits 1
  • Pipelines 4
  • Changes 3

This PR's main changes regarding setupVoutForWindow are:

  1. It moves much of the introspection into mainInstance.libraryWindow out of VLCVideoOutputProvider and into VLCLibraryWindow, where the actions that need doing to setup/unsetup video playback called by the setter of hasActiveVideo (which we always call regardless of the video window type)
  2. It moves the creation of the borderless window (video wallpaper / no decoration window) into its own function, reducing the complexity of setupVoutForWindow
  3. Cleans up redundant conditional cases and unnecessary assignments

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

Edited Aug 11, 2022 by Claudio Cambra
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/refactor-setupVoutForWindow

VideoLAN code repository instance