macosx: Refactor setupVoutForWindow in VLCVideoOutputProvider

This PR's main changes regarding setupVoutForWindow are:

1. It moves much of the introspection into mainInstance.libraryWindow out of VLCVideoOutputProvider and into VLCLibraryWindow, where the actions that need doing to setup/unsetup video playback called by the setter of hasActiveVideo (which we always call regardless of the video window type)
2. It moves the creation of the borderless window (video wallpaper / no decoration window) into its own function, reducing the complexity of setupVoutForWindow
3. Cleans up redundant conditional cases and unnecessary assignments

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

changed the description

added 1 commit

• b1998062 - macosx: Refactor setupVoutForWindow in VLCVideoOutputProvider

Compare with previous version

added MRStatus::Reviewable label

approved this merge request

changed milestone to %4.0

added Component::Interface: macOS Platform::macOS labels

added MRStatus::Acceptable label and removed MRStatus::Reviewable label

approved this merge request

added 60 commits

• b1998062...6dea7695 - 59 commits from branch videolan:master
• 3bf34cfb - macosx: Refactor setupVoutForWindow in VLCVideoOutputProvider

Compare with previous version

added MRStatus::Accepted label and removed MRStatus::Acceptable label

MR Acceptance result

This MergeRequest has been Accepted! Congratulations.

MR acceptance checks details:

• MR should be considered mergeable by Gitlab
• Last pipeline should be successful
• MergeRequest should have at least one external review and/or vote
• All threads should be resolved, have votes and score > 0
• MergeRequest should have no activity (threads/votes) for (72h/72h)

This message was automatically generated by homer-bot.

added 4 commits

• 3bf34cfb...cd238cef - 3 commits from branch videolan:master
• 1eb10010 - macosx: Refactor setupVoutForWindow in VLCVideoOutputProvider

Compare with previous version

merged