Skip to content
Snippets Groups Projects

macosx: Reload audio data source more cleanly, only when needed

Merged Claudio Cambra requested to merge claucambra/vlc:work/improved-audio-source-reload into master

The way the audio data source refreshes its data and views at the moment is a bit janky and often relies on brute-forcing by replacing the displayed collection array over and over again, leading to refreshing the collection view data and layout over and over again. This is inefficient and leads to things like album art flashing in collection views when it shouldn't (such as when a new song is set to play).

This PR includes changes that reset data and layouts only when it is needed, cutting down on most of the resetting that was previously going on.

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

Merge request reports

Merge request pipeline #247990 passed

Merge request pipeline passed for 21819cb0

Merged by Hugo Beauzée-LuyssenHugo Beauzée-Luyssen 2 years ago (Aug 2, 2022 5:41pm UTC)

Loading

Pipeline #247995 passed

Pipeline passed for 21819cb0 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading