Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • VLC VLC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.8k
    • Issues 3.8k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 287
    • Merge requests 287
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLANVideoLAN
  • VLCVLC
  • Merge requests
  • !2303

macosx: Reload audio data source more cleanly, only when needed

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Claudio Cambra requested to merge claucambra/vlc:work/improved-audio-source-reload into master Jul 29, 2022
  • Overview 4
  • Commits 1
  • Pipelines 3
  • Changes 2

The way the audio data source refreshes its data and views at the moment is a bit janky and often relies on brute-forcing by replacing the displayed collection array over and over again, leading to refreshing the collection view data and layout over and over again. This is inefficient and leads to things like album art flashing in collection views when it shouldn't (such as when a new song is set to play).

This PR includes changes that reset data and layouts only when it is needed, cutting down on most of the resetting that was previously going on.

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/improved-audio-source-reload

VideoLAN code repository instance