Skip to content
Snippets Groups Projects

macosx: Unify fetching in VLCLibraryDataTypes.m

Merged Claudio Cambra requested to merge claucambra/vlc:work/unify-item-fetching into master

This helps curb duplicated code in several classes (i.e. the audio group types such as albums, artists, etc.)

This PR also adds checks of the pointers returned by the media library item fetching functions (there are real conditions in which a null pointer could be returned by these, causing a crash)

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

Edited by Claudio Cambra

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Claudio Cambra added 1 commit

    added 1 commit

    • b45eba17 - macosx: Unify fetching in VLCLibraryDataTypes.m

    Compare with previous version

  • Marvin Scholz approved this merge request

    approved this merge request

  • Felix Paul Kühne approved this merge request

    approved this merge request

  • Felix Paul Kühne changed milestone to %4.0

    changed milestone to %4.0

  • Jean-Baptiste Kempf approved this merge request

    approved this merge request

  • Claudio Cambra added 26 commits

    added 26 commits

    Compare with previous version

  • Jean-Baptiste Kempf resolved all threads

    resolved all threads

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, have votes and score > 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (72h/72h)

    This message was automatically generated by homer-bot.

  • added 24 commits

    Compare with previous version

  • Jean-Baptiste Kempf enabled an automatic merge when the pipeline for 0a844c3b succeeds

    enabled an automatic merge when the pipeline for 0a844c3b succeeds

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading