macosx: Unify fetching in VLCLibraryDataTypes.m
This helps curb duplicated code in several classes (i.e. the audio group types such as albums, artists, etc.)
This PR also adds checks of the pointers returned by the media library item fetching functions (there are real conditions in which a null pointer could be returned by these, causing a crash)
Signed-off-by: Claudio Cambra claudio.cambra@gmail.com
Merge request reports
Activity
added MRStatus::Reviewable label
- Resolved by Claudio Cambra
I think it would be better to have a Class for this and instantiate an object on the App delegate or have a singleton returned by a
sharedMediaLibrary
on the class, like most of Apples classes offer.
- Resolved by Jean-Baptiste Kempf
added MRStatus::InReview label and removed MRStatus::Reviewable label
added 1 commit
- b45eba17 - macosx: Unify fetching in VLCLibraryDataTypes.m
changed milestone to %4.0
added Component::Interface: macOS label
added 26 commits
-
b45eba17...eb47c931 - 25 commits from branch
videolan:master
- a33a42fe - macosx: Unify fetching in VLCLibraryDataTypes.m
-
b45eba17...eb47c931 - 25 commits from branch
added MRStatus::Acceptable label and removed MRStatus::InReview label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
added 24 commits
-
a33a42fe...db807b51 - 23 commits from branch
videolan:master
- 0a844c3b - macosx: Unify fetching in VLCLibraryDataTypes.m
-
a33a42fe...db807b51 - 23 commits from branch
enabled an automatic merge when the pipeline for 0a844c3b succeeds