Skip to content
Snippets Groups Projects

omxil: fix memory leak on format convertion

Merged Max Romanov requested to merge mar0x/vlc:omxil_memleak_fix into master

After 8f42dc5c commit h264_avcC_to_AnnexB_NAL() and hevc_hvcC_to_AnnexB_NAL() are always allocate memory using malloc(). Allocated block assigned to pBuffer and changed initially allocated pointer value. According to OpenMAX specification, OMX component should not free this buffer and it will leak.

Furthermore, OMX component may rely on initially allocated buffer address.

Copying the data into the original buffer and free temporary memory block should fix both issues.

Merge request reports

Merge request pipeline #245375 passed

Merge request pipeline passed for 91b19f2b

Merged by Hugo Beauzée-LuyssenHugo Beauzée-Luyssen 2 years ago (Jul 26, 2022 7:17am UTC)

Loading

Pipeline #245381 passed

Pipeline passed for 91b19f2b on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading