You need to sign in or sign up before continuing.
macosx: Include NSAppearanceNameVibrantDark in dark mode detection, fixing borked labels
In master
, some labels are coloured incorrectly due to a faulty check for dark mode which doesn't account for NSAppearanceNameVibrantDark
. This PR adds this appearance to the dark mode check.
Fixed:
Prior to fix:
Signed-off-by: Claudio Cambra claudio.cambra@gmail.com
Merge request reports
Activity
Filter activity
added 1 commit
- 51897132 - macosx: Include NSAppearanceNameVibrantDark in dark mode detection, fixing borked labels
added 1 commit
- d60b9dac - macosx: Include NSAppearanceNameVibrantDark in dark mode detection, fixing borked labels
added MRStatus::Reviewable label
added MRStatus::Acceptable label and removed MRStatus::Reviewable label
changed milestone to %4.0
added Component::Interface: macOS Platform::macOS labels
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
added 30 commits
-
d60b9dac...c38bfea9 - 29 commits from branch
videolan:master
- 4989505a - macosx: Include NSAppearanceNameVibrantDark in dark mode detection, fixing borked labels
-
d60b9dac...c38bfea9 - 29 commits from branch
enabled an automatic merge when the pipeline for 4989505a succeeds
Please register or sign in to reply