Skip to content
Snippets Groups Projects

macosx: Include NSAppearanceNameVibrantDark in dark mode detection, fixing borked labels

In master, some labels are coloured incorrectly due to a faulty check for dark mode which doesn't account for NSAppearanceNameVibrantDark. This PR adds this appearance to the dark mode check.

Fixed:

Screenshot_2022-07-08_at_01.50.35

Prior to fix:

Screenshot_2022-07-08_at_01.54.17

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

Merge request reports

Merge request pipeline #240253 passed

Merge request pipeline passed for 4989505a

Approval is optional

Merged by Hugo Beauzée-LuyssenHugo Beauzée-Luyssen 2 years ago (Jul 11, 2022 7:30am UTC)

Merge details

  • Changes merged into with 4989505a.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #240572 passed

Pipeline passed for 4989505a on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading