contrib: vpx: update to 1.12.0

assigned to @tmatth

added Component::Build system: Contribs label

Failing on Apple ARM platforms with:

checking whether the C compiler works... Toolchain is unable to link executables

Configuration failed. This could reflect a misconfiguration of your
toolchains, improper options selected, or another problem. If you
don't see any useful error messages above, the next step is to look
at the configure error log file (config.log) to determine what
configure was trying to do when it died.
make: *** [.vpx] Error 1
make: *** Waiting for unfinished jobs....

so I'm guessing libvpx-ios.patch needs some additional tweaking.

approved this merge request

mentioned in merge request !2286 (merged)

changed milestone to %4.0

OK I think the issue was just that I accidentally dropped this blob:

diff --git a/contrib/src/vpx/libvpx-ios.patch b/contrib/src/vpx/libvpx-ios.patch
index df621b907f..dfc3a0d155 100644
--- a/contrib/src/vpx/libvpx-ios.patch
+++ b/contrib/src/vpx/libvpx-ios.patch
@@ -1,6 +1,8 @@
---- libvpx-1.12.0/build/make/configure.sh      2022-06-29 17:51:30.889112408 -0400
-+++ libvpx-1.12.0-new/build/make/configure.sh  2022-06-29 17:54:41.984884352 -0400
-@@ -861,100 +861,6 @@
+diff --git a/build/make/configure.sh b/build/make/configure.sh
+index 581042e38..5b282d666 100644
+--- a/build/make/configure.sh
++++ b/build/make/configure.sh
+@@ -861,100 +861,6 @@ process_common_toolchain() {
    # PIC is probably what we want when building shared libs
    enabled shared && soft_enable pic
  
@@ -101,3 +103,16 @@
    # Handle Solaris variants. Solaris 10 needs -lposix4
    case ${toolchain} in
      sparc-solaris-*)
+@@ -1143,12 +1049,6 @@ EOF
+               add_cflags -isysroot ${alt_libc}
+             fi
+ 
+-            if [ "${LD}" = "${CXX}" ]; then
+-              add_ldflags -miphoneos-version-min="${IOS_VERSION_MIN}"
+-            else
+-              add_ldflags -ios_version_min "${IOS_VERSION_MIN}"
+-            fi
+-
+             for d in lib usr/lib usr/lib/system; do
+               try_dir="${alt_libc}/${d}"
+               [ -d "${try_dir}" ] && add_ldflags -L"${try_dir}"