macosx: Fix toolbar segmented buttons bug and bring design closer to mockups
At the moment, the library window toolbar uses an older button style and smaller buttons that are different from the proposed designs. Additionally, prior to this PR, the toolbar would have a visual bug that would prevent all the buttons from being accessible:
This PR changes the style of the toolbar to more closely match the proposed designs, while also fixing the visual bug preventing the navigation buttons from being used:
The key changes visually are:
- Fixed the clipped segmented title buttons
- Increased the size of the segmented title buttons
- Moved the cone icon to the left of the navigation buttons
- Correctly centred the segmented title buttons
Merge request reports
Activity
Thanks
Thanks for your contribution!
When all of the following conditions are fulfilled, your MergeRequest will be reviewed by the Team:
- the check pipeline passes
- the MR is considered as 'mergeable' by gitlab
You can find more details about the acceptance process here.
added MRStatus::Reviewable label
added 1 commit
- 4ce26080 - macosx: Bring toolbar design closer to mockups
added 1 commit
- 0190abd5 - macosx: Bring toolbar design closer to mockups
requested review from @jbk
added MRStatus::Acceptable label and removed MRStatus::Reviewable label
changed milestone to %4.0
added Component::Interface: macOS Platform::macOS labels
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
added 100 commits
-
0190abd5...56a6ef98 - 99 commits from branch
videolan:master
- 2c872aed - macosx: Bring toolbar design closer to mockups
-
0190abd5...56a6ef98 - 99 commits from branch
enabled an automatic merge when the pipeline for 2c872aed succeeds
added MRStatus::NotCompliant label and removed MRStatus::Accepted label
added MRStatus::Accepted label and removed MRStatus::NotCompliant label