Skip to content
Snippets Groups Projects

macosx: Fix toolbar segmented buttons bug and bring design closer to mockups

Merged Claudio Cambra requested to merge claucambra/vlc:work/toolbar into master

At the moment, the library window toolbar uses an older button style and smaller buttons that are different from the proposed designs. Additionally, prior to this PR, the toolbar would have a visual bug that would prevent all the buttons from being accessible:

Screenshot_2022-06-21_at_00.06.21

This PR changes the style of the toolbar to more closely match the proposed designs, while also fixing the visual bug preventing the navigation buttons from being used:

Screenshot_2022-06-20_at_23.42.57

The key changes visually are:

  • Fixed the clipped segmented title buttons
  • Increased the size of the segmented title buttons
  • Moved the cone icon to the left of the navigation buttons
  • Correctly centred the segmented title buttons
Edited by Claudio Cambra

Merge request reports

Merge request pipeline #234883 passed

Merge request pipeline passed for 2c872aed

Approval is optional

Merged by Felix Paul KühneFelix Paul Kühne 2 years ago (Jun 25, 2022 7:38am UTC)

Merge details

  • Changes merged into master with 2c872aed.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #234914 passed

Pipeline passed for 2c872aed on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading