Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • VLC VLC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,801
    • Issues 3,801
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 257
    • Merge requests 257
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLANVideoLAN
  • VLCVLC
  • Merge requests
  • !2100

macosx: Fix toolbar segmented buttons bug and bring design closer to mockups

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Claudio Cambra requested to merge claucambra/vlc:work/toolbar into master Jun 20, 2022
  • Overview 2
  • Commits 1
  • Pipelines 4
  • Changes 3

At the moment, the library window toolbar uses an older button style and smaller buttons that are different from the proposed designs. Additionally, prior to this PR, the toolbar would have a visual bug that would prevent all the buttons from being accessible:

Screenshot_2022-06-21_at_00.06.21

This PR changes the style of the toolbar to more closely match the proposed designs, while also fixing the visual bug preventing the navigation buttons from being used:

Screenshot_2022-06-20_at_23.42.57

The key changes visually are:

  • Fixed the clipped segmented title buttons
  • Increased the size of the segmented title buttons
  • Moved the cone icon to the left of the navigation buttons
  • Correctly centred the segmented title buttons
Edited Jun 20, 2022 by Claudio Cambra
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/toolbar

VideoLAN code repository instance