macosx: Only set placeholder image and fetch artwork when necessary, preventing constant flashing of placeholder image

Currently, every time the control bar is updated (say to update the progress bar), the artwork flashes:

Screen_Recording_2022-06-18_at_19.59.36

This is because on each update, the artwork is set, even if it hasn't changed, with the placeholder image being set before the artwork has been fetched. Thus the flashing.

This MR changes this behaviour. VLCImageView stores a copy of the most recently set artwork URL and checks first if a URL has set, and if this URL is the same as the one about to be set, before applying the placeholder image and the new artwork URL.

After fixes:

Screen_Recording_2022-06-18_at_19.59.36

changed title from Only set placeholder image and fetch artwork when necessary, preventing constant flashing of placeholder image to macosx: Only set placeholder image and fetch artwork when necessary, preventing constant flashing of placeholder image

Thanks

Thanks for your contribution!

When all of the following conditions are fulfilled, your MergeRequest will be reviewed by the Team:

• the check pipeline passes
• the MR is considered as 'mergeable' by gitlab

You can find more details about the acceptance process here.

This message was automatically generated by homer-bot.

added MRStatus::Reviewable label

added MRStatus::InReview label and removed MRStatus::Reviewable label

added 1 commit

• 791808f8 - Only set placeholder image and fetch artwork when necessary, preventing...

Compare with previous version

resolved all threads

Nit: please shorten your commit title and limit the lenght or your commit log lines.

approved this merge request

added MRStatus::Acceptable label and removed MRStatus::InReview label

added Component::Interface: macOS label

added 1 commit

• 5bfb8050 - Only set VLCImageView placeholder image and fetch artwork when necessary

Compare with previous version

added 1 commit

• 41fc6428 - Only set VLCImageView images when necessary

Compare with previous version

resolved all threads

added MRStatus::InReview label and removed MRStatus::Acceptable label

added 1 commit

• 2fb5f3bc - macosx: Only set VLCImageView images when necessary

Compare with previous version

resolved all threads

added 68 commits

• 2fb5f3bc...9383a3e8 - 67 commits from branch videolan:master
• 35036fa4 - macosx: Only set VLCImageView images when necessary

Compare with previous version

approved this merge request

added MRStatus::Acceptable label and removed MRStatus::InReview label

approved this merge request

changed milestone to %4.0

added Platform::macOS label

added MRStatus::Accepted label and removed MRStatus::Acceptable label

MR Acceptance result

This MergeRequest has been Accepted! Congratulations.

MR acceptance checks details:

• MR should be considered mergeable by Gitlab
• Last pipeline should be successful
• MergeRequest should have at least one external review and/or vote
• All threads should be resolved, have votes and score > 0
• MergeRequest should have no activity (threads/votes) for (72h/72h)

This message was automatically generated by homer-bot.

added 32 commits

• 35036fa4...43c69bf2 - 31 commits from branch videolan:master
• 56a6ef98 - macosx: Only set VLCImageView images when necessary

Compare with previous version

merged