Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • VLC VLC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,801
    • Issues 3,801
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 253
    • Merge requests 253
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLANVideoLAN
  • VLCVLC
  • Merge requests
  • !2094

macosx: Only set placeholder image and fetch artwork when necessary, preventing constant flashing of placeholder image

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Claudio Cambra requested to merge claucambra/vlc:work/fix-artwork-flashing-controlbar into master Jun 18, 2022
  • Overview 10
  • Commits 1
  • Pipelines 7
  • Changes 1

Currently, every time the control bar is updated (say to update the progress bar), the artwork flashes:

Screen_Recording_2022-06-18_at_19.59.36

This is because on each update, the artwork is set, even if it hasn't changed, with the placeholder image being set before the artwork has been fetched. Thus the flashing.

This MR changes this behaviour. VLCImageView stores a copy of the most recently set artwork URL and checks first if a URL has set, and if this URL is the same as the one about to be set, before applying the placeholder image and the new artwork URL.

After fixes:

Screen_Recording_2022-06-18_at_19.59.36

Edited Jun 18, 2022 by Claudio Cambra
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/fix-artwork-flashing-controlbar

VideoLAN code repository instance