macosx: Emit the correct notifications in VLCLibraryModel
At the moment, we have several update methods that emit the same notification despite handling different media types/groupings
This MR corrects this and adds a missing notification for Genres
Merge request reports
Activity
Thanks
Thanks for your contribution!
When all of the following conditions are fulfilled, your MergeRequest will be reviewed by the Team:
- the check pipeline passes
- the MR is considered as 'mergeable' by gitlab
You can find more details about the acceptance process here.
added MRStatus::Reviewable label
added MRStatus::Acceptable label and removed MRStatus::Reviewable label
added 39 commits
-
277b9bc8...699fb535 - 38 commits from branch
videolan:master
- 258b889e - Ensure the correct notifications are being emitted in VLCLibraryModel
-
277b9bc8...699fb535 - 38 commits from branch
added Component::Interface: macOS label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
- Resolved by Marvin Scholz
Can you add the
macosx:
prefix to the actual commit message?
added 1 commit
- 8a58aa66 - macosx: Ensure the correct notifications are being emitted in VLCLibraryModel
added 68 commits
-
8a58aa66...9383a3e8 - 67 commits from branch
videolan:master
- a91d9d8f - macosx: Ensure the correct notifications are being emitted in VLCLibraryModel
-
8a58aa66...9383a3e8 - 67 commits from branch
enabled an automatic merge when the pipeline for a91d9d8f succeeds
changed milestone to %4.0
added Platform::macOS label