tracer: json: use a define for tick->tracer_time conversion
This fixes a timebase mismatch between values from tracer entries (NS vs US).
Merge request reports
Activity
changed milestone to %4.0
requested review from @alexandre-janniaux
assigned to @Garf
added MRStatus::Reviewable label
- Resolved by Thomas Guillem
I agree timestamp values should be consistent in the tracer, but given the fact the tracer was originally based on OpenTelemetry, I would keep the original nanosecond unit as it is proposed in the log specs:
https://opentelemetry.io/docs/reference/specification/logs/data-model/#field-timestamp
Edited by Simon Latapie
added MRStatus::InReview label and removed MRStatus::Reviewable label
added MRStatus::Acceptable label and removed MRStatus::InReview label
mentioned in merge request !1907 (merged)
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 44 commits
-
58bff67c...84659b15 - 41 commits from branch
videolan:master
- 1a54b8d2 - tracer: refector VLC_TRACE from ticks
- 20973203 - tracer: use a define for tick -> integer conversion
- 7ebb2d48 - tracer: json: use a define for tick -> integer conversion
Toggle commit list-
58bff67c...84659b15 - 41 commits from branch
enabled an automatic merge when the pipeline for 7ebb2d48 succeeds
added Component::Core label
mentioned in merge request !3745 (merged)