va_surface: fix potential double use of a buffer
Substracting 1 to refcount first, means it goes back to unused state temporarily. It may be picked by another thread as well before calling atomic_fetch_sub().
In the end we don't need the -1,+1 it's already in the "used once" state (2) after the atomic_compare_exchange() call.
Merge request reports
Activity
Filter activity
changed milestone to %4.0
added Component::Decoders Hw label
3.0 is unaffected as
va_pool_Get()
andGetSurface()
work differently.Edited by Steve LhommeRace condition introduced in fc8b0c8d
added MRStatus::Acceptable label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 4 commits
-
f812fe80...caf41ce2 - 3 commits from branch
videolan:master
- 35886895 - va_surface: fix potential double use of a buffer
-
f812fe80...caf41ce2 - 3 commits from branch
enabled an automatic merge when the pipeline for 35886895 succeeds
Please register or sign in to reply