Skip to content
Snippets Groups Projects

smb2: fix error handling when error is set from the generic_cb

Merged Thomas Guillem requested to merge tguillem/vlc:smb2-fix-check-status into master

Fixes issue reported via vlc-ios: VLCKit#597 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Felix Paul Kühne approved this merge request

    approved this merge request

  • Thomas Guillem mentioned in merge request !1745 (merged)

    mentioned in merge request !1745 (merged)

  • mentioned in merge request VLCKit!162 (merged)

  • Jean-Baptiste Kempf approved this merge request

    approved this merge request

  • Thomas Guillem added 41 commits

    added 41 commits

    • cbc96443...599191d3 - 36 commits from branch videolan:master
    • e8798d4a - smb2: homogenize status and error functions
    • 605bd1a2 - smb2: rework error handling from smb2_service_fd
    • 947aa88c - smb2: return errno directly
    • 0c4cd0ba - smb2: also clear op->smb2 in case of error
    • 95df96bb - smb2: destroy the context in case or errors from smb2_generic_cb

    Compare with previous version

  • Thomas Guillem resolved all threads

    resolved all threads

  • mentioned in merge request VLCKit!168 (merged)

  • Thomas Guillem resolved all threads

    resolved all threads

  • Thomas Guillem added 38 commits

    added 38 commits

    • 95df96bb...b7b5fd49 - 33 commits from branch videolan:master
    • 79f08657 - smb2: homogenize status and error functions
    • 6e964ddf - smb2: rework error handling from smb2_service_fd
    • cb5d44dd - smb2: return errno directly
    • 44401c95 - smb2: also clear op->smb2 in case of error
    • 2ac7ae1b - smb2: destroy the context in case or errors from smb2_generic_cb

    Compare with previous version

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, and score >= 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (24h/24h)

    This message was automatically generated by homer-bot.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading