input: source: properly release on `SlaveAdd` failure
Fix a leak happening when an input slave fails to load. Leak detected with asan:
Direct leak of 120 byte(s) in 1 object(s) allocated from:
#0 0x7f56cb985ad7 in calloc (/lib64/libasan.so.6)
#1 0x7f56cad22849 in InputSourceNew src/input/input.c:2605
#2 0x7f56cad2c9ca in input_SlaveSourceAdd src/input/input.c:3408
#3 0x7f56cad0f838 in LoadSlaves src/input/input.c:1164
#4 0x7f56cad1219a in Init src/input/input.c:1360
#5 0x7f56cad06092 in Run src/input/input.c:466
#6 0x7f56c9998b19 in start_thread (/lib64/libc.so.6)
Merge request reports
Activity
Filter activity
added MRStatus::Acceptable label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
added 48 commits
-
91dda0c1...02293b1d - 46 commits from branch
videolan:master
- 83ffc437 - input: refactor `SlaveSourceAdd` error handling
- caf66c91 - input: source: properly release on `SlaveAdd` failure
-
91dda0c1...02293b1d - 46 commits from branch
enabled an automatic merge when the pipeline for caf66c91 succeeds
changed milestone to %4.0
added Component::Core: Input label
Please register or sign in to reply