Skip to content
Snippets Groups Projects

xcb/x11: cover the whole parent window

Merged Rémi Denis-Courmont requested to merge Courmisch/vlc:x11 into master
All threads resolved!

To plot the black borders, we need our drawable to cover the entirety of the parent window.

Fixes #26495 (closed).

Merge request reports

Merge request pipeline #200316 passed

Merge request pipeline passed for 3168e929

Approval is optional

Merged by Hugo Beauzée-LuyssenHugo Beauzée-Luyssen 3 years ago (Mar 15, 2022 8:35am UTC)

Merge details

Pipeline #200326 passed

Pipeline passed for 3168e929 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Steve Lhomme resolved all threads

    resolved all threads

  • added 23 commits

    • 05489ad4...a32bf927 - 18 commits from branch videolan:master
    • 33424578 - xcb/x11: retain picture placement
    • d3f5df83 - xcb/x11: cover the whole parent window
    • 2f90b6b4 - xcb/x11: place SHM picture correctly
    • 488a0fe4 - xcb/x11: place non-SHM picture correctly
    • cc9a4acf - xcb/x11: black out the borders

    Compare with previous version

  • added 5 commits

    • 7eac7fa9 - xcb/x11: retain picture placement
    • de729244 - xcb/x11: cover the whole parent window
    • 17a43435 - xcb/x11: place SHM picture correctly
    • ba487047 - xcb/x11: place non-SHM picture correctly
    • 05489ad4 - xcb/x11: black out the borders

    Compare with previous version

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, and score >= 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (24h/24h)

    This message was automatically generated by homer-bot.

  • added 25 commits

    • 05489ad4...155036d4 - 20 commits from branch videolan:master
    • 3d1449c2 - xcb/x11: retain picture placement
    • d321530a - xcb/x11: cover the whole parent window
    • 9223f0d8 - xcb/x11: place SHM picture correctly
    • 5e93159d - xcb/x11: place non-SHM picture correctly
    • 3168e929 - xcb/x11: black out the borders

    Compare with previous version

  • Hugo Beauzée-Luyssen enabled an automatic merge when the pipeline for 3168e929 succeeds

    enabled an automatic merge when the pipeline for 3168e929 succeeds

  • Please register or sign in to reply
    Loading