url: fix platforms with unsigned char (!1526) · Merge requests · VideoLAN / VLC · GitLab

Snippets Groups Projects

Merged Rémi Denis-Courmont requested to merge Courmisch/vlc:url into master 3 years ago

Mar 05, 2022
- url: use signed type as needed · 7550e1ff
  Rémi Denis-Courmont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago
```
Errors are signaled by -1, so the type has to be signed.

There are no needs to force 8-bit sign extension here since the
non-error result is always positive. So better use a fast type.

Regression from 88e3a4f0.
Fixes #26679.
```
  7550e1ff
- url: don't force 8-bit masking · 3028c3b9
  Rémi Denis-Courmont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago
```
If a subtraction underflows, we do not care what the exact result is,
only that it is large.
```
  3028c3b9
- url: pick type to avoid casts · cdfea222
  Rémi Denis-Courmont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago
  
  cdfea222

VideoLAN code repository instance