decklink: add default virtual destructor (!1368) · Merge requests · VideoLAN / VLC

Alexandre Janniaux requested to merge alexandre-janniaux/vlc:decklink-destructor/1 into master Feb 08, 2022

The class has virtual functions and is calling delete this; so it triggers a warning if the class has no virtual destructors.

modules/access/decklink.cpp: In member function ‘virtual ULONG {anonymous}::DeckLinkCaptureDelegate::Release()’:
modules/access/decklink.cpp:268:13: warning: deleting object of polymorphic class type ‘{anonymous}::DeckLinkCaptureDelegate’ which has non-virtual destructor might cause undefined behavior [-Wdelete-non-virtual-dtor]
  268 |             delete this;
      |             ^~~~~~~~~~~

decklink: add default virtual destructor

Merge request reports