adjust: remove brightness threshold
No matter how you look at it, this did not belong in the image adjust filter. This could belong in a separate module, or as a submodule of the colour threshold filter -- if somebody actually ever needs it.
This function was never implemented by the hardware-accelerated adjust filters, as it is indeed not a standard part of HSL and HSV adjustment functionality, or really at all a part of it. So this has actually become a functional inconsistency.
Merge request reports
Activity
added Component::Video: filters label
added MRStatus::Reviewable label
added MRStatus::Acceptable label and removed MRStatus::Reviewable label
/!\ On Windows, !1361 (merged) should be merged before this, so we do not get a run-time conflict on the configuration items.
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations. MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 9 commits
-
6be23683...a5a1fe7f - 6 commits from branch
videolan:master
- 24bddada - adjust: remove brightness threshold
- 2e01716b - adjust: reindent
- 44b82fa6 - macos: disable brightness threshold
Toggle commit list-
6be23683...a5a1fe7f - 6 commits from branch
added 8 commits
-
44b82fa6...ca13fe63 - 5 commits from branch
videolan:master
- 2553ba0d - adjust: remove brightness threshold
- ba55578f - adjust: reindent
- 7418ccda - macos: disable brightness threshold
Toggle commit list-
44b82fa6...ca13fe63 - 5 commits from branch
enabled an automatic merge when the pipeline for 7418ccda succeeds
changed milestone to %4.0