RFC: vout/macosx: fix heap-buffer-overflow by using vlc_gl_Create()

vlc_gl_HasExtension requires vlc_gl_t be created by vlc_gl_Create, otherwise:

==15037==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60c00040e0c8 at pc 0x0001003436ae bp 0x70000acc6af0 sp 0x70000acc6ae8
READ of size 8 at 0x60c00040e0c8 thread T20
    #0 0x1003436ad in vlc_gl_HasExtension opengl.c:206
    #1 0x10bdc1ee3 in vlc_gl_api_Init gl_api.c:180
    #2 0x10bdaa077 in vout_display_opengl_New vout_helper.c:110
    #3 0x10bd94882 in Open macosx.m:236

I don't know how to test the second patch, ./vlc-osx-static -vv --vout caopengllayer doesn't work.

changed title from vout/macosx: fix heap-buffer-overflow by using vlc_gl_Create() to RFC: vout/macosx: fix heap-buffer-overflow by using vlc_gl_Create()

changed the description

You should do the code moving (or not) in separate commits so we can tell which part is actually a fix and what part is just code moving.

Thanks for finding and trying to fix that, but it looks a bit hackish since any other client of OpenGL provider could be provided an empty OpenGL module too.

I'll remove this module very soon, to cut it into a opengl provider only.

2022年1月28日 下午5:03，"Alexandre Janniaux (@alexandre-janniaux)" gitlab@videolan.org写道：

Sounds better. You can close the MR now.

See !1316 ;)

The code here is forcing a specific GL module. So it is not pretty, but still safe, AFAICT.

I mean the opposite actually. With the display gl, and --gl=cao_gl, you'd have an OpenGL implementation which doesn't have its glView.

added MRStatus::Reviewable label

added MRStatus::InReview label and removed MRStatus::Reviewable label

mentioned in merge request !1316

mentioned in issue #26606 (closed)

closed

mentioned in merge request !1383 (closed)