macos: expand set of string handling macros
As requested in the !1172 (merged) discussion, this introduces macros similar to those used in the Qt plugin (introduced in 6cd08480), which are ignored by the mechanism that scans for strings to be translated.
Additionally, in fixing this I happened to:
- Remove a duplicate null check in the macros.
- Fix a few cases of double translation lookups.
- Fix the few remaining cases not making use of the
module_Get(Short|Long)Name()
helpers.
Merge request reports
Activity
mentioned in merge request !1172 (merged)
added MRStatus::Reviewable label
assigned to @fkuehne
requested review from @ePirat
added 5 commits
Toggle commit listadded 55 commits
-
bae49888...c5ebfdf6 - 47 commits from branch
videolan:master
- 39740333 - macos: remove duplicate null check
- cb1ebf37 - macos: tweak translation string marker macro set
- a47f4911 - macos: replace all use of `_NS()` on defines and variables
- b0ac0bf5 - macos: fix duplicate translation of cat/subcat labels
- 7df4dbd4 - macos: fix unwanted translation lookup of option names
- 932d2e31 - macos: use `module_GetShortName()` helper
- 6fd6990f - qt: use `module_GetShortName()` helper
- 628de3ca - rtp: use `module_GetLongName()` helper
Toggle commit list-
bae49888...c5ebfdf6 - 47 commits from branch
- Resolved by Lyndon Brown
- Resolved by Lyndon Brown
- Resolved by Lyndon Brown
- Resolved by Lyndon Brown
added MRStatus::InReview label and removed MRStatus::Reviewable label
added 7 commits
- 9b062357 - macos: add a separate alternative macro for non-translation marker use
- bf9f9ed5 - macos: replace all use of `_NS()` on defines and variables
- 79bfe9a4 - macos: fix duplicate translation of cat/subcat labels
- 4a411f34 - macos: fix unwanted translation lookup of option names
- 3c0dd0c4 - macos: use `module_GetShortName()` helper
- 7962e068 - qt: use `module_GetShortName()` helper
- ac39c380 - rtp: use `module_GetLongName()` helper
Toggle commit list- Resolved by Lyndon Brown
added 7 commits
- 928d439c - macos: add a separate alternative macro for non-translation marker use
- 7e669ff9 - macos: replace all use of `_NS()` on defines and variables
- e3eea940 - macos: fix duplicate translation of cat/subcat labels
- eb4b24dc - macos: fix unwanted translation lookup of option names
- fdd1d4e9 - macos: use `module_GetShortName()` helper
- 2d64a913 - qt: use `module_GetShortName()` helper
- ba2b7777 - rtp: use `module_GetLongName()` helper
Toggle commit listadded 34 commits
-
eb4b24dc...f45fd76f - 30 commits from branch
videolan:master
- 4d07d6a7 - macos: add a separate alternative macro for non-translation marker use
- 27abc136 - macos: replace all use of `_NS()` on defines and variables
- 1711c7c4 - macos: fix duplicate translation of cat/subcat labels
- 04442524 - macos: fix unwanted translation lookup of option names
Toggle commit list-
eb4b24dc...f45fd76f - 30 commits from branch
added MRStatus::Acceptable label and removed MRStatus::InReview label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
added 125 commits
-
04442524...3b46bf98 - 121 commits from branch
videolan:master
- 8038904e - macos: add a separate alternative macro for non-translation marker use
- a785740a - macos: replace all use of `_NS()` on defines and variables
- ce1b46c3 - macos: fix duplicate translation of cat/subcat labels
- e791b513 - macos: fix unwanted translation lookup of option names
Toggle commit list-
04442524...3b46bf98 - 121 commits from branch
changed milestone to %4.0