Skip to content
Snippets Groups Projects

Qt: Redundant signal binding

Merged ya zou requested to merge zouya/vlc:master into master
All threads resolved!

The signal slot binding here is redundant, because every time the menu is created, the value is obtained from MainInterface, and there is no need to set it again through the signal.

fixes #25664 (closed)

Edited by ya zou

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • ya zou changed the description

    changed the description

  • ya zou resolved all threads

    resolved all threads

  • assigned to @chub

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, have votes and score > 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (72h/72h)

    This message was automatically generated by homer-bot.

  • added 58 commits

    Compare with previous version

  • Hugo Beauzée-Luyssen enabled an automatic merge when the pipeline for 37d8b6f8 succeeds

    enabled an automatic merge when the pipeline for 37d8b6f8 succeeds

  • Please register or sign in to reply
    Loading