Qt: Redundant signal binding
All threads resolved!
All threads resolved!
The signal slot binding here is redundant, because every time the menu is created, the value is obtained from MainInterface, and there is no need to set it again through the signal.
fixes #25664 (closed)
Edited by ya zou
Merge request reports
Activity
Filter activity
added MRStatus::Reviewable label
- Resolved by ya zou
added MRStatus::InReview label and removed MRStatus::Reviewable label
added Component::Interface: Qt label
assigned to @chub
added MRStatus::Acceptable label and removed MRStatus::InReview label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
added 58 commits
-
1b26a559...2550346b - 57 commits from branch
videolan:master
- 37d8b6f8 - Qt: Redundant signal binding
-
1b26a559...2550346b - 57 commits from branch
enabled an automatic merge when the pipeline for 37d8b6f8 succeeds
Please register or sign in to reply