core: fix jaro-winkler heap-buffer-overflow
The implementation could read beyond the b
string.
I encountered this crash by passing --opengl-filter=mock
with an incorrect environment, but it could be reproduced with:
$ ./vlc --opaaaaaaa
…
Error: Unknown option `--opaaaaaaa'
=================================================================
==522294==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000022655 at pc 0x7f8b1793d73d bp 0x7ffe311de800 sp 0x7ffe311de7f8
READ of size 1 at 0x602000022655 thread T0
#0 0x7f8b1793d73c in jaro_inner ../../src/config/jaro_winkler.c:111
#1 0x7f8b1793db7a in vlc_jaro_winkler ../../src/config/jaro_winkler.c:159
Merge request reports
Activity
Filter activity
changed milestone to %4.0
added MRStatus::Reviewable label
added MRStatus::Acceptable label and removed MRStatus::Reviewable label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 5 commits
-
55f95c55...f1603b69 - 3 commits from branch
videolan:master
- 55995aa4 - core: fix incorrect use of ssize_t
- 52ef980f - core: fix jaro-winkler heap-buffer-overflow
-
55f95c55...f1603b69 - 3 commits from branch
enabled an automatic merge when the pipeline for 52ef980f succeeds
Please register or sign in to reply