Skip to content
Snippets Groups Projects

core: fix jaro-winkler heap-buffer-overflow

Merged Romain Vimont requested to merge rom1v/vlc:fix_jaro into master

The implementation could read beyond the b string.

I encountered this crash by passing --opengl-filter=mock with an incorrect environment, but it could be reproduced with:

$ ./vlc --opaaaaaaa

Error: Unknown option `--opaaaaaaa'
=================================================================
==522294==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000022655 at pc 0x7f8b1793d73d bp 0x7ffe311de800 sp 0x7ffe311de7f8
READ of size 1 at 0x602000022655 thread T0
    #0 0x7f8b1793d73c in jaro_inner ../../src/config/jaro_winkler.c:111
    #1 0x7f8b1793db7a in vlc_jaro_winkler ../../src/config/jaro_winkler.c:159

Merge request reports

Merge request pipeline #175897 passed

Merge request pipeline passed for 52ef980f

Approval is optional

Merged by Romain VimontRomain Vimont 3 years ago (Jan 4, 2022 3:51pm UTC)

Merge details

  • Changes merged into master with 52ef980f.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #175915 passed

Pipeline passed for 52ef980f on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading