samba: use the new API
And fix potential data races, that could have become criticial with the new medialibary (more than one samba access in //). Indeed, the SMBCCTX and SMBCFILE were stored statically and fetch from an unique fd without any lock mechanism.
Merge request reports
Activity
changed milestone to %4.0
added Component::Core: Input label
- Resolved by Thomas Guillem
Depends on !758 (merged)
added MRStatus::Reviewable label
- Resolved by Thomas Guillem
added MRStatus::InReview label and removed MRStatus::Reviewable label
added 39 commits
-
f25f846a...785d1745 - 37 commits from branch
videolan:master
- d4065935 - samba: limit the read size
- a3f04493 - samba: use the new API
-
f25f846a...785d1745 - 37 commits from branch
added MRStatus::NotCompliant label and removed MRStatus::InReview label
added 3 commits
-
a3f04493...abf527b5 - 2 commits from branch
videolan:master
- 223d01c2 - samba: use the new API
-
a3f04493...abf527b5 - 2 commits from branch
added MRStatus::Acceptable label and removed MRStatus::NotCompliant label
- Resolved by Thomas Guillem
added MRStatus::InReview label and removed MRStatus::Acceptable label
- Resolved by Thomas Guillem
Waiting reviews for !1020 (3ea71c06)
It seems weird we never saw this issue, I would love feedbacks.
Edited by Thomas Guillem
- Resolved by Thomas Guillem
added MRStatus::NotCompliant label and removed MRStatus::InReview label
added MRStatus::InReview label and removed MRStatus::NotCompliant label
added MRStatus::NotCompliant label and removed MRStatus::InReview label
added MRStatus::Acceptable label and removed MRStatus::NotCompliant label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 34 commits
-
a80ab727...3c486ed9 - 33 commits from branch
videolan:master
- 2a6a684d - samba: use the new API
-
a80ab727...3c486ed9 - 33 commits from branch
enabled an automatic merge when the pipeline for 2a6a684d succeeds