Add hotkey option to display the media title
This adds the ability to set a hotkey that shows the current media
title on the OSD, the same that is shown when media starts playing
and the video-title-show
option is true.
Fix #7967
Note: If this approach is acceptable, I can squash the commits to not have the unnecessarily late API change, but do it together with the refactor commit.
A different approach to exposing vout_DisplayItemTitle
would be to
add a new function to the player, vlc_player_DisplayPosition(player, item);
and call the resource's DisplayVoutTitle
there.
Merge request reports
Activity
changed milestone to %4.0
added Component::Core: Video output label
added MRStatus::Reviewable label
360 360 VLC_TICK_FROM_MS(sys->title.timeout), title); 361 361 } 362 362 363 void vout_DisplayItemTitle(vout_thread_t *vout, input_item_t *item) Ok, how about the proposal to have it on the player instead that just shows it for the current item, so I would not need to pass it the item at all?
And we already have the time OSD function on the player so if we decide to unify those, it would probably be fitting to have it there.
173 173 ACTIONID_JUMP_BACKWARD_LONG, 174 174 ACTIONID_JUMP_FORWARD_LONG, 175 175 ACTIONID_POSITION, 176 ACTIONID_SHOW_TITLE, This action that is so niche that it cannot be assigned a default hotkey. And because it has no hotkey, basically nobody will use it.
Ultimately, title is not something that changes like time (for which there is a hotkey). This could work if T would show both, but as a standalone, this is guaranteed to be nothing but feature check-boxing.
added MRStatus::InReview label and removed MRStatus::Reviewable label
added MRStatus::NotCompliant label and removed MRStatus::InReview label