Skip to content
Snippets Groups Projects

Add hotkey option to display the media title

Open Marvin Scholz requested to merge ePirat/vlc:epirat-add-osd-title-action into master
2 unresolved threads

This adds the ability to set a hotkey that shows the current media title on the OSD, the same that is shown when media starts playing and the video-title-show option is true.

Fix #7967

Note: If this approach is acceptable, I can squash the commits to not have the unnecessarily late API change, but do it together with the refactor commit.

A different approach to exposing vout_DisplayItemTitle would be to add a new function to the player, vlc_player_DisplayPosition(player, item); and call the resource's DisplayVoutTitle there.

Edited by Marvin Scholz

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
360 360 VLC_TICK_FROM_MS(sys->title.timeout), title);
361 361 }
362 362
363 void vout_DisplayItemTitle(vout_thread_t *vout, input_item_t *item)
  • 173 173 ACTIONID_JUMP_BACKWARD_LONG,
    174 174 ACTIONID_JUMP_FORWARD_LONG,
    175 175 ACTIONID_POSITION,
    176 ACTIONID_SHOW_TITLE,
    • This looks pretty much useless to me.

    • Author Developer

      Can you elaborate?

    • This action that is so niche that it cannot be assigned a default hotkey. And because it has no hotkey, basically nobody will use it.

      Ultimately, title is not something that changes like time (for which there is a hotkey). This could work if T would show both, but as a standalone, this is guaranteed to be nothing but feature check-boxing.

    • Author Developer

      Well it can change for live streams, which is the main reason why I think its useful to have to begin with, else it would be indeed relatively useless.

      Personally I would be absolutely for it to change the "show time" and "show title" to a general "show status" that shows both.

    • IMO, combining both would be far better. In any case, we also need to filter out stupid useless names that fill the whole video, such as thousand of characters long URLs.

    • Please register or sign in to reply
  • Please register or sign in to reply
    Loading