auhal: save original stream format for digital aout fails which lead to nonfunctional module in subsequent pcm playback

Start SPDIF playback, plug out cable --> format is reset to pcm on stop.

Then, plug cable in. Actual format is not saved to pcm as it would be expected, but is read as AC3 already. Then, reverting this setting in stop fails. (This leads to crashes in current debug builds because of wrong error path.) More important, starting pcm audio afterwards leads to completely broken auhal module.

[0x1002b1e10] auhal audio output debug: attempting to use device 40
[0x1002b1e10] auhal audio output debug: found 12 stream formats for stream id 41
[0x1002b1e10] auhal audio output debug: supported format: [96000,000000][mcpl][4][8][1][8][2][24]
[0x1002b1e10] auhal audio output debug: supported format: [48000,000000][mcpl][4][8][1][8][2][24]
[0x1002b1e10] auhal audio output debug: supported format: [44100,000000][mcpl][4][8][1][8][2][24]
[0x1002b1e10] auhal audio output debug: supported format: [96000,000000][mcpl][4][8][1][8][2][20]
[0x1002b1e10] auhal audio output debug: supported format: [48000,000000][mcpl][4][8][1][8][2][20]
[0x1002b1e10] auhal audio output debug: supported format: [44100,000000][mcpl][4][8][1][8][2][20]
[0x1002b1e10] auhal audio output debug: supported format: [96000,000000][mcpl][12][4][1][4][2][16]
[0x1002b1e10] auhal audio output debug: supported format: [48000,000000][mcpl][12][4][1][4][2][16]
[0x1002b1e10] auhal audio output debug: supported format: [44100,000000][mcpl][12][4][1][4][2][16]
[0x1002b1e10] auhal audio output debug: supported format: [96000,000000][3cac][76][6144][1536][0][2][16]
[0x1002b1e10] auhal audio output debug: supported format: [48000,000000][3cac][76][6144][1536][0][2][16]
[0x1002b1e10] auhal audio output debug: supported format: [44100,000000][3cac][76][6144][1536][0][2][16]
[0x1002b1e10] auhal audio output debug: Using audio device for digital output
[0x1002b1e10] auhal audio output debug: original stream format: [48000,000000][3cac][76][6144][1536][0][2][16] <---
[0x1002b1e10] auhal audio output debug: setting stream format: [48000,000000][3cac][76][6144][1536][0][2][16]

added Component::Audio: macOS / iOS / tvOS / visionOS Severity::normal Type::bug Version::master git labels

changed milestone to %2.1.x maintenance bugs

changed the description

changed title from auhal: save original stream format fails which lead to crashed in subsequent playback to auhal: save original stream format for digital aout fails which lead to nonfunctional module in subsequent pcm playback

assigned to @dfuhrmann and unassigned @MigrationBot

commit eb72c5a3 Author: David Fuhrmann david.fuhrmann@googlemail.com Date: Mon Nov 25 19:48:40 2013 +0100

auhal: fix crash on error paths for stream format change

ref [#9957](https://code.videolan.org/videolan/vlc/-/issues/9957)

Original author: david.fuhrmann@googlemail.com

changed milestone to %Bugs paradize

changed milestone to %2.2.0

commit c6d2ba70 Author: David Fuhrmann david.fuhrmann@googlemail.com Date: Mon Feb 24 12:43:26 2014 +0100

auhal: prevent revert to unusual formats after SPDIF playback

Getting the current format is unreliable, for instance if the audio
cable is plugged in while playback is running. Thus only the
first original format is trusted.

close [#9957](https://code.videolan.org/videolan/vlc/-/issues/9957)

Original author: david.fuhrmann@googlemail.com

added Status::fixed label

closed