Need to convert all commandline arguments into unicode

While fixing #830 (closed), I've moved the unicode conversion of argv[] into Win32-specific system init. It turned out, that it's better to convert all arguments, since it enables the user to use localised filenames also in global or mrl-specific options, e.g.:

--sout=std{access=file,mux=ts,dst="Prvá časť.mpg"}

:sout=std{access=file,mux=ts,dst="Prvá časť.mpg"}

The code also has a comment pointing this way:

/* FIXME: should we convert options to UTF-8 as well ?? */

So I suggest to do it for other OSs as well.

changed the description

I must be missing something. MacOS and BeOS are already UTF-8 and need no conversion. Linux usually needs no conversion either nowadays (and if it does, I think we are already doing it).

There are basically two problems left:

• the conversion is being done inside libvlc (i.e. it's also performed for Java/Python bindings etc. although those are typically UTF-capable).

• the conversion is only performed for MRL filenames. No conversion happens for global options and/or MRL specific options.

As of now, we only need conversion for VLC executable if it's being run on UNIX with legacy codepage - so it should be done in VLC's main(), and for all arguments.

On Win32 it's already implemented this way.

assigned to @Courmisch

(In [19223]) setlocale() (very) early, so we may have a chance to use nl_langinfo before initializing LibVLC (refs #838 (closed))

(In [19330]) - Make FromLocale() usable any time (after setlocale()) - refs #838 (closed)

• Fix re-entrancy problem for multiple LibVLC in the same process

(In [19331]) Remove too late and partial command line charset conversion - refs #838 (closed) Note that this provisionaly breaks the command line on non-UTF-8 non-Win32 systems

(In [19332]) Convert from locale before passing to LibVLC - closes #838 (closed)

added Status::fixed label

closed

mentioned in issue #920 (closed)