Regressions in S/PDIF handling

Now that spidf is basically working, several regressions can be found easily, ranging from "plugin is not usable anymore" failures, tries to open spdif even if no spdif device is present, up to crashes because of wrong frees (audio device list!).

Just plug in and out the spdif cable while audio is playing and not playing, and try several scenarios.

Update - Remaining issues:

• listener needed for event that spdif is available again to: update devices list, restart aout

• default output device is broken sometimes: 0 is no valid id. Resulting fallback to default device does not work in some cases (play digital, then unplug spdif cable, then select default device --> default device variable is also 0)

added Component::Audio: macOS / iOS / tvOS / visionOS Severity::normal Type::bug Version::master git labels

changed milestone to %2.1.0 release

assigned to @dfuhrmann and unassigned @fkuehne

I am trying to fix some of these directly spdif related problems (plugging out cable while output is running).

Felix, if you want, feel free to assign some problems to you which are introduced in your code (audio device list, the default device and spdif related handling to that...).

commit f27f834d Author: David Fuhrmann david.fuhrmann@googlemail.com Date: Sun Mar 10 18:39:00 2013 +0100

auhal: fix memory corruption crash when device list changes (refs [#8286](https://code.videolan.org/videolan/vlc/-/issues/8286))

Original author: david.fuhrmann@googlemail.com

changed the description

commit dd306ec4 Author: David Fuhrmann david.fuhrmann@googlemail.com Date: Fri Apr 5 20:36:09 2013 +0200

auhal: fix device setup when no spidf available

refs [#8286](https://code.videolan.org/videolan/vlc/-/issues/8286)

Original author: david.fuhrmann@googlemail.com

commit afc967f6 Author: David Fuhrmann david.fuhrmann@googlemail.com Date: Wed Apr 10 17:17:20 2013 +0200

auhal: reorganize listener registration for devices list and physical formats list

- Fixes detection when spidf is available again, and resumes playing in spdif mode
  if this was selected before
- Fixes audio device list rebuilt if no audio is playing

refs [#8286](https://code.videolan.org/videolan/vlc/-/issues/8286)

Original author: david.fuhrmann@googlemail.com

unassigned @dfuhrmann

Remaining bug is: play digital, then unplug spdif cable, then select default device. The debug output is below. Code results in silent playback.

[0x10028eb40] main audio output debug: restart requested (2)
[0x100822cb0] main audio resampler debug: removing module "ugly_resampler"
[0x100a61eb0] main audio converter debug: removing module "a52tofloat32"
[0x1008fccb0] main audio filter debug: removing module "scaletempo"
[0x100a84ab0] main audio converter debug: removing module "simple_channel_mixer"
[0x10028eb40] main audio output debug: restarting output...
[0x10028eb40] main audio output debug: VLC is looking for: 'a52 ' 48000 Hz 3F2R/LFE frame=1536 samples/1536 bytes
[0x10028eb40] auhal audio output debug: attempting to use device 0
[0x10028eb40] auhal audio output warning: could not check whether device [0x0] is alive: jbo!
[0x10028eb40] auhal audio output warning: selected audio device is not alive, switching to default device with id 0
[0x10028eb40] auhal audio output error: could not get number of streams: [jbo!] (560947818)
[0x10028eb40] auhal audio output warning: could not set alive check callback on device [0x0]: jbo!
[0x10028eb40] auhal audio output warning: could not check whether device is hogged: jbo!
[0x10028eb40] auhal audio output debug: current format is: [48000,000000][mcpl][9][8][1][8][2][32]
[0x10028eb40] auhal audio output warning: this driver does not support kAudioDevicePropertyPreferredChannelLayout. BAD DRIVER AUTHOR !!!
[0x10028eb40] auhal audio output debug: selected 2 physical channels for device output
[0x10028eb40] auhal audio output debug: VLC will output: Stereo
[0x10028eb40] auhal audio output debug: we set the AU format: [48000,000000][mcpl][9][8][1][8][2][32]
[0x10028eb40] auhal audio output debug: the actual set AU format is [48000,000000][mcpl][9][8][1][8][2][32]
[0x10028eb40] auhal audio output debug: analog output successfully opened

assigned to @fkuehne

commit 1cb158c9 Author: Felix Paul Kühne fkuehne@videolan.org Date: Thu Apr 25 12:41:57 2013 +0200

auhal: fix SPDIF -> default device fallback if SPDIF device is unplugged during playback (close [#8286](https://code.videolan.org/videolan/vlc/-/issues/8286))

added Status::fixed label

closed