ffmpeg Flac encoder broken

Flac encoding with ffmpeg is broken, result won't play anywhere, with ogg and raw muxing.

Flac encoding with libflac plays fine, with ogg and raw muxing.

little script to create samples:

=== for i in ffmpeg flac

do for j in raw ogg

do vlc -I dummy test.wav --sout "#transcode{acodec=flac,aenc=

There was an error rendering this math block. KaTeX parse error: Expected 'EOF', got '}' at position 2: i}̲:standard{acces…

i.

$j,mux=$

j}" vlc:quit

done

done

flac test.wav -o test-flac-standalone.flac

ffmpeg -i test.wav test-ffmpeg-standalone.flac

===

-rw-r--r-- 1 fun fun 39161718 oct 31 00:28 test-ffmpeg-standalone.flac

-rw-r--r-- 1 fun fun 39160641 oct 31 00:27 test-ffmpeg.raw

diff -a test-ffmpeg-standalone.flac test-ffmpeg.raw 2>/dev/null|wc -c

4209

4 kilobytes of difference for 40 mega bytes of data, not a lot

Also, why are two encoders for flac needed ?

added Component::Stream output: Encoders Severity::normal Type::bug Version::master git + 1 deleted label

changed milestone to %0.9.0-test1

changed milestone to %Bugs paradize

assigned to @funman and unassigned @MigrationBot

When using avcodec encoder, the last-metadata-block flag isn't set :

http://flac.sourceforge.net/format.html#metadata_block_header

Setting this bit to 1 produces a valid stream.

I believe ffmpeg encoder doesn't set it, and avformat changes this bit at the end of muxing.

To be investigated

commit 5fe7435e Author: Rafaël Carré rafael.carre@gmail.com Date: Sun Oct 18 17:11:45 2009 +0200

avcodec encoder: sets last-metadata-block for FLAC streams

Closes [#805](https://code.videolan.org/videolan/vlc/-/issues/805)

Original author: rafael.carre@gmail.com

added Status::fixed label

closed

commit 67f5fd87f720e5a2bbde0a09caeb30cf96c9be4c Author: Rafaël Carré rafael.carre@gmail.com Date: Sun Oct 18 17:11:45 2009 +0200

avcodec encoder: sets last-metadata-block for FLAC streams

Closes [#805](https://code.videolan.org/videolan/vlc/-/issues/805)
(cherry picked from commit 5fe7435e7f6d785d0668cede62bbce533601ad22)

Signed-off-by: Rafaël Carré <rafael.carre@gmail.com>

Original author: rafael.carre@gmail.com

changed milestone to %1.0.0-release