VLC fails to build on Ubuntu 12.10

The VLC master branch fails to build on Ubuntu 12.10 (quantal) since a few days:

../../doltlibtool --tag=CC  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../..  -DMODULE_NAME=$(p="libxcb_glx_plugin_la-opengl.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_NAME_IS_$(p="libxcb_glx_plugin_la-opengl.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}") -DMODULE_STRING=\"$(p="libxcb_glx_plugin_la-opengl.lo"; p="${p##*/}"; p="${p#lib}"; echo "${p%_plugin*}")\" -D__PLUGIN__ -I../../include -I../../include -D_FORTIFY_SOURCE=2   -I/usr/include/libdrm   -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Wvolatile-register-var -Werror-implicit-function-declaration -pipe -fvisibility=hidden -ffast-math -funroll-loops -fomit-frame-pointer -c -o libxcb_glx_plugin_la-opengl.lo `test -f 'opengl.c' || echo './'`opengl.c
opengl.c:179:5: error: unknown type name 'PFNGLCLIENTACTIVETEXTUREPROC'
opengl.c: In function 'vout_display_opengl_New':
opengl.c:330:33: error: 'PFNGLCLIENTACTIVETEXTUREPROC' undeclared (first use in this function)
opengl.c:330:33: note: each undeclared identifier is reported only once for each function it appears in
opengl.c:330:62: error: expected ';' before 'vlc_gl_GetProcAddress'
opengl.c: In function 'vout_display_opengl_GetPool':
opengl.c:603:41: error: called object 'vgl->ClientActiveTexture' is not a function
opengl.c: In function 'vout_display_opengl_Prepare':
opengl.c:662:37: error: called object 'vgl->ClientActiveTexture' is not a function
opengl.c:691:37: error: called object 'vgl->ClientActiveTexture' is not a function
opengl.c: In function 'draw_without_shaders':
opengl.c:782:32: error: called object 'vgl->ClientActiveTexture' is not a function
opengl.c:793:29: error: called object 'vgl->ClientActiveTexture' is not a function
opengl.c:801:32: error: called object 'vgl->ClientActiveTexture' is not a function
opengl.c:807:29: error: called object 'vgl->ClientActiveTexture' is not a function
opengl.c: In function 'draw_with_shaders':
opengl.c:830:33: error: called object 'vgl->ClientActiveTexture' is not a function
opengl.c:842:29: error: called object 'vgl->ClientActiveTexture' is not a function
opengl.c: In function 'vout_display_opengl_Display':
opengl.c:901:29: error: called object 'vgl->ClientActiveTexture' is not a function
make[5]: *** [libxcb_glx_plugin_la-opengl.lo] Error 1
make[5]: *** Waiting for unfinished jobs....
make[5]: Leaving directory `/build/buildd/vlc-2.1.0~~git20121006+r2081/modules/video_output'
make[4]: *** [all] Error 2

Here's the full build log: https://launchpadlibrarian.net/118720191/buildlog_ubuntu-quantal-amd64.vlc_2.1.0~~git20121006%2Br2081-0r87quantal1_FAILEDTOBUILD.txt.gz

This bug only appears under ubuntu Quantal (please ignore previous attachment :( )

Original author: https://launchpad.net/~inizan-yannick

Replying to [comment:1 https://launchpad.net/~inizan-yannick]:

This bug only appears under ubuntu Quantal (please ignore previous attachment :( )

Attachment deleted.

Probably caused by this:

commit 1858bcb81decc70ebdab6c2fef9d273bd57d74b3
Author: Ilkka Ollakka <ileoo@videolan.org>
Date:   Fri Mar 23 10:24:05 2012 +0200

    opengl: use ActiveTexture instead of ARB variant

I don't have recent enough Ubuntu to check and it works fine on Debian Sid. I don't know if it's a VLC or Ubuntu bug.

added Component::Video: X11 label

copy this line outside the "define" conditions seems to fix the bug

#   define PFNGLCLIENTACTIVETEXTUREPROC      typeof(glClientActiveTexture)*

tested under ubuntu 12.10, successfully packaged.

Added attachment:

• opengl.c

I can confirm that vlc builds on Ubuntu 12.04 and 12.10 if the proposed change is applied.

Same on Arch, since the Mesa 9 update.

I must say, I am not a big fan of the typeof approach, as it is GCC-specific.

I guess gl(Client)ActiveTexture functions are mandatory and thus Mesa-GL considers they should be accessed directly. As I already stated on other occasions, I think we should split the OpenGL (ES) 1 and OpenGL (ES) 2 back-ends. It's become to messy. Alternatively, we could require OpenGL 2 and use the overlay on older systems.

assigned to @Courmisch

changed milestone to %2.1.x maintenance bugs

commit 5989169a Author: Rémi Denis-Courmont remi@remlab.net Date: Wed Oct 24 19:49:13 2012 +0300

OpenGL: use gl(|Client)ActiveTexture directly (fixes [#7558](https://code.videolan.org/videolan/vlc/-/issues/7558))

glActiveTexture() seems mandatory.
glClientActiveTexture() requires OpenGL version >= 1.3.
Currently, OpenGL version >= 1.4 is assumed anyway.

Original author: remi@remlab.net

added Status::fixed label

closed