Linux fr_FR.UTF-8, HTTP interface status.xml : float printed with comma

Tested with the latest version of VLC (2.0.0-8) under Archlinux :

If vlc is started with default locale set to: fr_FR.UTF-8, or if started with this command line: LANG=fr_FR.UTF-8 vlc, the float number printed inside the status.xml are using comma instead of dot.

However if vlc is started with the locale "en_US.UTF-8" or "C", everything is fine, number are printed with dot.

The reason of opening this ticket is this problem is impacting a lot of android vlc remote applications.

added Component::Interface: HTTP server Difficulty::easy Severity::normal Type::bug labels

changed milestone to %2.0.x maintenance bugs

I think it is doing what is expected from the code.

changed milestone to %Bugs paradize

I don't really know lua, but this "ugly" patch of httprequests.lua fix the problem :

  function xmlString(s)
   if (type(s)=="string") then
       return vlc.strings.convert_xml_special_chars(s)
   elseif (type(s)=="number") then
       local strNum = nil
       local foo = 0
       strNum,foo = tostring(s):gsub(",", ".", 1)
       return strNum
   else
       return tostring(s)
   end
 end

I don't know if this normal that the tostring(s) function of lua (with s a number) is returning a string with a comma instead of a dot... I am going to dig a little bit on that question :-)

Original author: https://www.google.com/accounts/o8/id?id=aitoawlm0iqonkph9kfrzrk5hmaaswc6za99oeu

Well now I know why lua is putting a comma... After some digging into the source code of lua, I discover that the tostring function finally call this function : sprintf, but this function is locale dependent as I know A small test program to confirm :

#include <stdio.h>
#include <locale.h>

int main(int argc, char**argv)
{
        char s[100];
        double n = 12.46;
        setlocale (LC_ALL, "");
        // Source code of lua to be able to convert a number to a string :
        // luaconf.h: #define lua_number2str(s,n)   sprintf((s), LUA_NUMBER_FMT, (n))
        sprintf((s), "%.14g", (n));
        printf("%s  %f", s, n);
        return 0;
}

The result is (with locale set to fr_FR.UTF-8)

12,46

Original author: https://www.google.com/accounts/o8/id?id=aitoawlm0iqonkph9kfrzrk5hmaaswc6za99oeu

assigned to @linkfanel and unassigned @MigrationBot

added Component::LUA scripts label and removed Component::Interface: HTTP server label

commit 1e9dc296 Author: Pierre Ynard linkfanel@yahoo.fr Date: Sun Mar 25 05:04:40 2012 +0200

lua http: use us_tostring() to fix locale issues with decimals

The function is a bit ugly but it's difficult to do this using
pure arithmetic.

Fixes [#6378](https://code.videolan.org/videolan/vlc/-/issues/6378)

Original author: linkfanel@yahoo.fr

added Status::fixed label

closed

changed milestone to %2.0.2