XVideo output: green lines

Sample: http://www.listatrento.com/lockergnome.mp4

added Component::Core: Video output Severity::normal Type::bug Version::master git labels

changed milestone to %1.1.3

unassigned @Courmisch

This affects both SHM and non-SHM cases, and seems like a regression in VLC 1.1.0.

I can't find anything wrong in the VLC XV plugin though.

VLC 1.1.0 had the same problem. Even on a files that mplayer plays without these green line and through the same XVideo output.

This patches workaround it for me but it degrades performances on non mod16 video as direct rendering will be disabled (ie the video pictures will be copied).

diff --git a/modules/video_output/xcb/xvideo.c b/modules/video_output/xcb/xvideo.c
index 8b8190c..90097db 100644
--- a/modules/video_output/xcb/xvideo.c
+++ b/modules/video_output/xcb/xvideo.c
@@ -252,8 +252,8 @@ FindFormat (vout_display_t *vd,
             continue;
 
         /* VLC pads scanline to 16 pixels internally */
-        unsigned width = (fmt->i_width + 15) & ~15;
-        unsigned height = (fmt->i_height + 15) & ~15;
+        unsigned width = fmt->i_width;
+        unsigned height = fmt->i_height;
         xcb_xv_query_image_attributes_reply_t *i;
         i = xcb_xv_query_image_attributes_reply (conn,
             xcb_xv_query_image_attributes (conn, port, f->id,

It degrades performances only when direct rendering can effectively be used, for example with mpeg2/mpeg4-asp/... Which is not the case with this sample file as it uses H264, and avcodec wants extra padding lines for h264 (and xcb xv doesn't provides them).

added Status::fixed label

closed

mentioned in issue #12622 (closed)