lineorder of Hebrew subs.

http://forum.videolan.org/viewtopic.php?t=14063

Patch

[code] From: barakori@gmail.com Subject: [vlc-devel] Fixing RTL (Mainly Hebrew and Arabic) subtitles problems Date: 21 november 2005 18:57:48 GMT+01:00[/code]

[code] Index: modules/misc/freetype.c

--- modules/misc/freetype.c (revision 13308) +++ modules/misc/freetype.c (working copy) @@ -526,10 +526,34 @@ #if defined(HAVE_FRIBIDI) { uint32_t *p_fribidi_string;

   FriBidiCharType base_dir = FRIBIDI_TYPE_ON;
   p_fribidi_string = malloc( (i_string_length + 1) * sizeof(uint32_t) );

   fribidi_log2vis( (FriBidiChar*)psz_unicode, i_string_length,

                    &base_dir, (FriBidiChar*)p_fribidi_string, 0, 0, 0 );

```
  /* Do bidi conversion line-by-line */
```
```
  int pos = 0;
```
```
  while(pos < i_string_length) 
```
```
  {
```
```
  	while(pos < i_string_length) {
```
```
  		i_char = psz_unicode[pos];
```

  		if (i_char != '\r' && i_char != '\n')

```
  			break;
```
```
  		p_fribidi_string[pos] = i_char;
```
```
  		++pos;
```
```
  	}
```
```
  	int start_pos = pos;
```
```
  	while(pos < i_string_length) {
```
```
  		i_char = psz_unicode[pos];
```

  		if (i_char == '\r' || i_char == '\n')

```
  			break;
```
```
  		++pos;
```
```
  	}
```
```
  	if (pos > start_pos)
```
```
  	{
```

          FriBidiCharType base_dir = FRIBIDI_TYPE_LTR;

  		fribidi_log2vis((FriBidiChar*)psz_unicode + start_pos, pos - start_pos,

  			&base_dir, (FriBidiChar*)p_fribidi_string + start_pos, 0, 0, 0);

```
  	}
```
```
  }
```

   free( psz_unicode_orig );
   psz_unicode = psz_unicode_orig = p_fribidi_string;
   p_fribidi_string[ i_string_length ] = 0;

[/code]

assigned to @hartman

changed milestone to %0.8.5-final

(In [13691]) * hebrew line order fixes. patch by Barak Ori (barakori at gmail dot com) (closes #369 (closed))

added Status::fixed label

closed

lineorder of Hebrew subs.

Child items 0

Activity

[code] Index: modules/misc/freetype.c