SIGPIPE causes macosx vlc to exit when streaming via ftp

On Mac OS X, SIG_BLOCK of SIGPIPE is not enough to prevent SIGPIPE from being delivered when the ftp connection is unexpectedly terminated.

Something similar was reported in #2762 (closed), but not for ftp and the problem wasn't resolved.

Simply adding this solves the problem:

diff --git a/bin/vlc.c b/bin/vlc.c
index 55f7c5f..63be396 100644
--- a/bin/vlc.c
+++ b/bin/vlc.c
@@ -119,6 +119,8 @@ int main( int i_argc, const char *ppsz_argv[] )
     sigdelset (&set, SIGPIPE);
     sigdelset (&set, SIGCHLD);
 
+    signal(SIGPIPE, SIG_IGN);
+
     /* Note that FromLocale() can be used before libvlc is initialized */
     const char *argv[i_argc + 3];
     int argc = 0;

changed the description

assigned to @Courmisch

added Component::Core: Input label

Sorry but using signal() and pthread_sigmask() on the same signal is not defined.

added Status::will not fix label

closed

I would like this ticket reopened please. The fix may not be acceptable, but the problem really does exist!

From investigating a bit more, it seems like pthread_sigmask() does not apply to the "main" thread. That is calling pthread_sigmask() from main does not actually block the signals.

For example, I can send SIGTERM to the main vlc process and it will exit immediately, rather than requiring two signals two seconds apart.

I don't necessarily agree with your assertion that using signal() and pthread_sigmask() can't be used together. signal() (or sigaction()) should be able to set a default signal disposition for the process. It probably should be done before any call to pthread_sigmask() though.

I'm open to other solutions to this problem.

removed Status::will not fix label

reopened

Well my assertion was incorrect. sigwait(), not pthread_sigmask(), conflicts with sigaction() (and hence expectedly with signal() too). Fortunately, we don't call sigwait() on SIGPIPE.

But this "fix" might cause unexpected EINTR errors, and does not solve the libvlc case. IOW, the only way to properly fix this is to fix the bug, which lies in OS X, not in VLC.

added Status::fixed label

closed