macOS: Crash when opening folder from file browser

Nightly build: Compiled by videolanci with clang 15.0.0 (clang-1500.3.9.4) (Feb 1 2025 05:07:03)

Click browse on left side --> Double click movies --> Choose a subfolder with movies inside, clickk once on the play button of this folder.

-------------------------------------
Translated Report (Full Report Below)
-------------------------------------

Process:               VLC [14821]
Path:                  /Users/USER/VLC 4.app/Contents/MacOS/VLC
Identifier:            org.videolan.vlc
Version:               4.0.0-dev (4.0.0-dev)
Code Type:             ARM-64 (Native)
Parent Process:        launchd [1]
User ID:               501

Date/Time:             2025-02-01 15:35:04.2460 +0100
OS Version:            macOS 15.3 (24D60)
Report Version:        12
Anonymous UUID:        C868D947-CE11-51B3-D5CD-567780A0ED78

Sleep/Wake UUID:       F01A6E0F-57CC-4C9A-9089-4C52C96B2FB4

Time Awake Since Boot: 110000 seconds
Time Since Wake:       561 seconds

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000

Termination Reason:    Namespace SIGNAL, Code 6 Abort trap: 6
Terminating Process:   VLC [14821]

Application Specific Information:
abort() called


Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	       0x197d23720 __pthread_kill + 8
1   libsystem_pthread.dylib       	       0x197d5bf70 pthread_kill + 288
2   libsystem_c.dylib             	       0x197c68908 abort + 128
3   libc++abi.dylib               	       0x197d1244c abort_message + 132
4   libc++abi.dylib               	       0x197d00a40 demangling_terminate_handler() + 348
5   libobjc.A.dylib               	       0x1979a93e4 _objc_terminate() + 156
6   libc++abi.dylib               	       0x197d11710 std::__terminate(void (*)()) + 16
7   libc++abi.dylib               	       0x197d14cdc __cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*) + 88
8   libc++abi.dylib               	       0x197d14c84 __cxa_throw + 92
9   libobjc.A.dylib               	       0x19799ee40 objc_exception_throw + 448
10  CoreFoundation                	       0x197f6c1d8 -[NSObject(NSObject) doesNotRecognizeSelector:] + 364
11  libmacosx_plugin.dylib        	       0x1054d35d4 -[VLCLibraryAbstractSegmentViewController currentDataSource] + 44
12  libmacosx_plugin.dylib        	       0x1054d3668 -[VLCLibraryAbstractSegmentViewController disconnect] + 40
13  libmacosx_plugin.dylib        	       0x10550d1ec -[VLCLibraryWindow enableVideoPlaybackAppearance] + 888
14  libmacosx_plugin.dylib        	       0x10550bd58 -[VLCLibraryWindow setHasActiveVideo:] + 108
15  libmacosx_plugin.dylib        	       0x10565cfe8 -[VLCVideoOutputProvider setupVideoOutputForVideoWindow:withVlcWindow:] + 340
16  libmacosx_plugin.dylib        	       0x10565d54c -[VLCVideoOutputProvider setupVoutForWindow:withProposedVideoViewPosition:] + 420
17  libmacosx_plugin.dylib        	       0x10565eeac __WindowEnable_block_invoke + 72
18  libdispatch.dylib             	       0x197ba95b4 _dispatch_client_callout + 20
19  libdispatch.dylib             	       0x197bb8ee0 _dispatch_async_and_wait_invoke + 92
20  libdispatch.dylib             	       0x197ba95b4 _dispatch_client_callout + 20
21  libdispatch.dylib             	       0x197bb8040 _dispatch_main_queue_drain + 984
22  libdispatch.dylib             	       0x197bb7c58 _dispatch_main_queue_callback_4CF + 44
23  CoreFoundation                	       0x197e839d0 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 16
24  CoreFoundation                	       0x197e435bc __CFRunLoopRun + 1996
25  CoreFoundation                	       0x197e42734 CFRunLoopRunSpecific + 588
26  HIToolbox                     	       0x1a33b1530 RunCurrentEventLoopInMode + 292
27  HIToolbox                     	       0x1a33b7348 ReceiveNextEventCommon + 676
28  HIToolbox                     	       0x1a33b7508 _BlockUntilNextEventMatchingListInModeWithFilter + 76
29  AppKit                        	       0x19b9ba848 _DPSNextEvent + 660
30  AppKit                        	       0x19c320c24 -[NSApplication(NSEventRouting) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 688
31  AppKit                        	       0x19b9ad874 -[NSApplication run] + 480
32  libmacosx_plugin.dylib        	       0x10555957c __OpenIntf_block_invoke + 860
33  CoreFoundation                	       0x197e44430 __CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 28
34  CoreFoundation                	       0x197e44340 __CFRunLoopDoBlocks + 356
35  CoreFoundation                	       0x197e43770 __CFRunLoopRun + 2432
36  CoreFoundation                	       0x197e42734 CFRunLoopRunSpecific + 588
37  CoreFoundation                	       0x197ebd9d0 CFRunLoopRun + 64
38  VLC                           	       0x102a5ad0c main + 1704
39  dyld                          	       0x1979dc274 start + 2840

changed milestone to %4.0

added Component::Interface: macOS label

created branch 28958-macos-crash-when-opening-folger-from-file-browser to address this issue

changed title from macOS: Crash when opening folger from file browser to macOS: Crash when opening folder from file browser

I can reproduce

One valid fix would be to remove [self doesNotRecognizeSelector:_cmd]; from [VLCLibraryAbstractSegmentViewController currentDataSource] as this is purposefully implemented in the media source view controller

A better solution would be to replace use of VLCLibraryAbstractSegmentViewController with a protocol IMO

assigned to @claucambra

mentioned in merge request !6820 (merged)

closed with merge request !6820 (merged)